Fix crash with 'gdal vector pipeline read my.shp --layer my ! sql --sql ... ! ...'

Author: rouault

apps/gdalalg_vector_read.cpp

@@ -49,6 +49,7 @@ class GDALVectorPipelineReadOutputDataset final : public GDALDataset
 
   public:
     explicit GDALVectorPipelineReadOutputDataset(GDALDataset &oSrcDS);
+    ~GDALVectorPipelineReadOutputDataset() override;
 
     void AddLayer(OGRLayer &oSrcLayer);
 
@@ -74,10 +75,20 @@ GDALVectorPipelineReadOutputDataset::GDALVectorPipelineReadOutputDataset(
     GDALDataset &srcDS)
     : m_srcDS(srcDS)
 {
+    m_srcDS.Reference();
     SetDescription(m_srcDS.GetDescription());
     poDriver = m_srcDS.GetDriver();
 }
 
+/************************************************************************/
+/*                GDALVectorPipelineReadOutputDataset()                 */
+/************************************************************************/
+
+GDALVectorPipelineReadOutputDataset::~GDALVectorPipelineReadOutputDataset()
+{
+    m_srcDS.ReleaseRef();
+}
+
 /************************************************************************/
 /*           GDALVectorPipelineReadOutputDataset::AddLayer()            */
 /************************************************************************/

autotest/utilities/test_gdalalg_vector_pipeline.py

@@ -1080,3 +1080,14 @@ def test_gdalalg_vector_pipeline_decorated_ds_take_ref(tmp_vsimem):
     ds = ogr.Open(f"{tmp_vsimem}/out.shp")
     lyr = ds.GetLayer(0)
     assert lyr.GetFeatureCount() == 1
+
+
+def test_gdalalg_vector_pipeline_read_ds_take_ref(tmp_vsimem):
+
+    gdal.alg.vector.pipeline(
+        pipeline=f'read ../ogr/data/poly.shp ! read --layer poly ! sql --sql "select * from poly" ! write {tmp_vsimem}/out.shp'
+    )
+
+    ds = ogr.Open(f"{tmp_vsimem}/out.shp")
+    lyr = ds.GetLayer(0)
+    assert lyr.GetFeatureCount() == 10