fix(tv): materialize TV request search before filtering to avoid EF Core 500 (#5421)

* fix(tv): materialize TV request search before filtering to avoid EF Core translation error

The SearchTvRequest method applied a Where clause using the custom
StringHelper.Contains overload on an IQueryable, causing EF Core to
attempt (and fail) to translate it to SQL, returning HTTP 500.

Materialize the results with ToListAsync first, then filter in memory,
mirroring MovieRequestEngine.SearchMovieRequest.

Fixes #5420

* ci: remove duplicate 'spec' key in automation-tests smoke step

The Cypress smoke test step defined 'spec' twice, making the workflow
file invalid. Remove the stray duplicate so the workflow parses and runs.

Author: tidusjar

.github/workflows/automation-tests.yml

@@ -238,7 +238,6 @@ jobs:
         spec: "cypress/features/01-wizard/wizard.feature,cypress/features/login/login.feature,cypress/tests/login/login.spec.ts"
         wait-on: http://localhost:3577/
         wait-on-timeout: 600
-        spec: cypress/features/01-wizard/wizard.feature
       env:
         CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

src/Ombi.Core/Engine/TvRequestEngine.cs

@@ -645,7 +645,9 @@ public async Task<IEnumerable<TvRequests>> SearchTvRequest(string search)
             {
                 allRequests = TvRepository.Get();
             }
-            var results = await allRequests.Where(x => x.Title.Contains(search, CompareOptions.IgnoreCase)).ToListAsync();
+            var results = (await allRequests.ToListAsync())
+                .Where(x => x.Title.Contains(search, CompareOptions.IgnoreCase))
+                .ToList();
 
             await FillAdditionalFields(shouldHide, results);
             return results;