feat(requests): add compact view, sorting and user filtering to requests list (#5424)

* feat(requests): add compact view, sorting and user filtering to requests list

Addresses the feedback in #5422 about the card redesign losing the old
table's capabilities:

- Compact (table) view for movies, TV and albums with a cards/compact
  toggle persisted per media type; column headers are click-to-sort
- Sort controls (field dropdown + direction toggle) in both views,
  persisted and applied server-side
- Requested-by user filter for admins/power users, applied server-side
  via a new optional requestedBy query parameter on the v2 request
  list endpoints
- Fix music request sorting: ascending order previously always sorted
  by requested date, and the sort property was resolved against the
  wrong entity type

* chore: relax global.json SDK rollForward to latestMajor

Allows building with any newer installed .NET SDK when the pinned
8.0.419 feature band is not available locally.

* style(requests): redesign toolbar with cohesive pill controls

Replace the stock Material outline selects with custom pill-style
menu buttons that match the existing filter chips and dark theme:

- User filter, sort field and page size become rounded pill buttons
  backed by mat-menu, with icons, carets and an accent highlight
  when a user filter is active
- Sort field + direction joined into a single segmented pill group
- View toggle restyled as a rounded segmented control
- Dark dropdown panels with an accent check on the active option
- Select All wrapped in a matching pill

* style(requests): align Select All with the pill toolbar design

Replace the raw Material checkbox in the toolbar with a pill toggle
button matching the other controls. The icon reflects selection state
(empty square / minus for partial / check for all) and the pill lights
up in the accent colour while anything is selected.

* fix: address CodeRabbit review — safer SDK roll-forward and stylelint block disable

- global.json: revert rollForward from latestMajor to latestMinor so the
  build stays within .NET 8 rather than potentially picking up .NET 9/10
- _shared-card-grid.scss: replace stylelint-disable-next-line with a
  block-style disable/enable pair so both ::ng-deep selectors in the
  comma-separated rule are suppressed

* fix(engines): address self-review findings — auth, null-ref, and double-query bugs

- FilterByRequestedUser: add isAdmin guard so only admins/power-users can
  filter the request list by another user's ID; unauthenticated or
  non-admin callers receive the full (or HideRequestsUsers-scoped) list
  unchanged
- Add HideResult.IsAdmin flag set by HideFromOtherUsers so the engine
  methods can pass the caller's privilege level without an extra
  IsInRole call
- Fix NullReferenceException in all six sort blocks: extend the
  sortProperty.Contains('.') guard to also cover prop == null, which
  occurs when the client sends an unrecognised property name
- Fix double DB round-trip in MovieRequestEngine.GetRequestsByStatus:
  sort the already-materialised 'requests' list instead of re-issuing
  allRequests.ToList(), which was a redundant second query

* perf(engines): push ORDER BY to DB; fix TV paginator total after DistinctBy

Movies and Music:
- Replace TypeDescriptor reflection sort with static ApplySortMovies /
  ApplySortAlbums helpers that build typed IQueryable expressions, so
  ORDER BY + LIMIT/OFFSET execute server-side instead of loading the
  full table into memory first
- Remove System.ComponentModel import (TypeDescriptor no longer used)

TV (ChildRequests already loaded in-memory due to FilterChildren):
- Replace TypeDescriptor reflection sort with ApplySortTv switch
  expression (same semantics, no reflection overhead)
- Move total = allRequests.Count to AFTER DistinctBy in all three
  GetRequests / GetRequestsByStatus / GetUnavailableRequests methods;
  previously total was computed before de-duplication so the paginator
  showed more pages than actually existed

* test: fix IAsyncQueryProvider failures and restore sort-by-id case

- MovieRequestEngineTests: replace movies.AsQueryable() with
  movies.AsQueryable().BuildMock() on all GetWithUser() setups so that
  CountAsync / ToListAsync have an IAsyncQueryProvider (required after
  the engine methods were updated to use EF async operators)
- Add "id" branch to ApplySortMovies / ApplySortAlbums / ApplySortTv;
  the test suite uses sortProperty="id" for deterministic ordering and
  the TypeDescriptor-based approach handled it implicitly; the explicit
  switch needs to be kept in sync

* fix(cypress): align TV grid element IDs with TMDB show ID for E2E tests

TV grid was using item.id (DB auto-increment PK) for element IDs but
Cypress tests identify rows by the TMDB show ID (externalProviderId).
Switch all card-grid ID bindings to item.parentRequest.externalProviderId
so selectors like #detailsButton60735 resolve correctly.

Also update the page object: requestsToDisplayDropdown now points to
#gridCountButton (renamed in redesign), and getRowCheckbox now uses
#adminSelectCheckbox to match the movie grid template.

https://claude.ai/code/session_01GcnVpVpeRah1KpH2g77oBr

Author: tidusjar

src/Ombi.Core.Tests/Engine/MovieRequestEngineTests.cs

@@ -124,7 +124,7 @@ public async Task RemoveMovieRequest_DoesNotNotify_WhenUserCannotManageRequest()
         public async Task GetRequestByStatus_PendingRequests_Non4K()
         {
             var movies = RegularRequestData();
-            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable());
+            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable().BuildMock());
 
             var result = await _subject.GetRequestsByStatus(10, 0, "id", "asc", Models.Requests.RequestStatus.PendingApproval);
 
@@ -169,7 +169,7 @@ public async Task GetRequestByStatus_PendingRequests_4K()
                     RequestedDate = DateTime.MinValue
                 }
             };
-            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable());
+            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable().BuildMock());
 
             var result = await _subject.GetRequestsByStatus(10, 0, "id", "asc", RequestStatus.PendingApproval);
 
@@ -216,7 +216,7 @@ public async Task GetRequestByStatus_PendingRequests_Both4K_And_Regular()
                     RequestedDate = DateTime.MinValue
                 }
             };
-            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable());
+            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable().BuildMock());
 
             var result = await _subject.GetRequestsByStatus(10, 0, "id", "asc", RequestStatus.PendingApproval);
 
@@ -230,7 +230,7 @@ public async Task GetRequestByStatus_PendingRequests_Both4K_And_Regular()
         public async Task GetRequestByStatus_ProcessingRequests_Non4K()
         {
             var movies = RegularRequestData();
-            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable());
+            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable().BuildMock());
 
             var result = await _subject.GetRequestsByStatus(10, 0, "id", "asc", Models.Requests.RequestStatus.ProcessingRequest);
 
@@ -275,7 +275,7 @@ public async Task GetRequestByStatus_ProcessingRequests_4K()
                     RequestedDate = DateTime.MinValue
                 }
             };
-            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable());
+            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable().BuildMock());
 
             var result = await _subject.GetRequestsByStatus(10, 0, "id", "asc", RequestStatus.ProcessingRequest);
 
@@ -323,7 +323,7 @@ public async Task GetRequestByStatus_ProcessingRequests_Both4K_And_Regular()
                     RequestedDate = DateTime.Now
                 }
             };
-            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable());
+            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable().BuildMock());
 
             var result = await _subject.GetRequestsByStatus(10, 0, "id", "asc", RequestStatus.ProcessingRequest);
 
@@ -337,7 +337,7 @@ public async Task GetRequestByStatus_ProcessingRequests_Both4K_And_Regular()
         public async Task GetRequestByStatus_AvailableRequests_Non4K()
         {
             List<MovieRequests> movies = RegularRequestData();
-            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable());
+            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable().BuildMock());
 
             var result = await _subject.GetRequestsByStatus(10, 0, "id", "asc", Models.Requests.RequestStatus.Available);
 
@@ -384,7 +384,7 @@ public async Task GetRequestByStatus_AvailableRequests_4K()
                     RequestedDate = DateTime.MinValue
                 }
             };
-            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable());
+            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable().BuildMock());
 
             var result = await _subject.GetRequestsByStatus(10, 0, "id", "asc", RequestStatus.Available);
 
@@ -433,7 +433,7 @@ public async Task GetRequestByStatus_AvailableRequests_Both4K_And_Regular()
                     RequestedDate = DateTime.Now
                 }
             };
-            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable());
+            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable().BuildMock());
 
             var result = await _subject.GetRequestsByStatus(10, 0, "id", "asc", RequestStatus.Available);
 
@@ -446,7 +446,7 @@ public async Task GetRequestByStatus_AvailableRequests_Both4K_And_Regular()
         public async Task GetRequestByStatus_DeniedRequests_Non4K()
         {
             List<MovieRequests> movies = RegularRequestData();
-            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable());
+            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable().BuildMock());
 
             var result = await _subject.GetRequestsByStatus(10, 0, "id", "asc", Models.Requests.RequestStatus.Denied);
 
@@ -491,7 +491,7 @@ public async Task GetRequestByStatus_DeniedRequests_4K()
                     RequestedDate = DateTime.MinValue
                 }
             };
-            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable());
+            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable().BuildMock());
 
             var result = await _subject.GetRequestsByStatus(10, 0, "id", "asc", RequestStatus.Denied);
 
@@ -541,7 +541,7 @@ public async Task GetRequestByStatus_DeniedRequests_Both4K_And_Regular()
                     RequestedDate = DateTime.Now
                 }
             };
-            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable());
+            _repoMock.Setup(x => x.GetWithUser()).Returns(movies.AsQueryable().BuildMock());
 
             var result = await _subject.GetRequestsByStatus(10, 0, "id", "asc", RequestStatus.Denied);
 

src/Ombi.Core/Engine/BaseMediaEngine.cs

@@ -152,14 +152,25 @@ public RequestCountModel RequestCount()
             };
         }
 
+        protected static IQueryable<T> FilterByRequestedUser<T>(IQueryable<T> requests, string requestedByUserId, bool isAdmin) where T : BaseRequest
+        {
+            if (!isAdmin || string.IsNullOrEmpty(requestedByUserId))
+            {
+                return requests;
+            }
+
+            return requests.Where(x => x.RequestedUserId == requestedByUserId);
+        }
+
         protected async Task<HideResult> HideFromOtherUsers()
         {
             var user = await GetUser();
             if (await IsInRole(OmbiRoles.Admin) || await IsInRole(OmbiRoles.PowerUser) || user.IsSystemUser)
             {
                 return new HideResult
                 {
-                    UserId = user.Id
+                    UserId = user.Id,
+                    IsAdmin = true
                 };
             }
             var settings = await Cache.GetOrAddAsync(CacheKeys.OmbiSettings, () => OmbiSettings.GetSettingsAsync());
@@ -255,6 +266,7 @@ public class HideResult
         {
             public bool Hide { get; set; }
             public string UserId { get; set; }
+            public bool IsAdmin { get; set; }
         }
     }
 }

src/Ombi.Core/Engine/IMusicRequestEngine.cs

@@ -22,7 +22,7 @@ public interface IMusicRequestEngine
         Task<RequestEngineResult> RequestAlbum(MusicAlbumRequestViewModel model);
         Task<IEnumerable<AlbumRequest>> SearchAlbumRequest(string search);
         Task<bool> UserHasRequest(string userId);
-        Task<RequestsViewModel<AlbumRequest>> GetRequestsByStatus(int count, int position, string sort, string sortOrder, RequestStatus available);
-        Task<RequestsViewModel<AlbumRequest>> GetRequests(int count, int position, string sort, string sortOrder);
+        Task<RequestsViewModel<AlbumRequest>> GetRequestsByStatus(int count, int position, string sort, string sortOrder, RequestStatus available, string requestedByUserId = null);
+        Task<RequestsViewModel<AlbumRequest>> GetRequests(int count, int position, string sort, string sortOrder, string requestedByUserId = null);
     }
 }

src/Ombi.Core/Engine/Interfaces/IMovieRequestEngine.cs

@@ -21,11 +21,11 @@ public interface IMovieRequestEngine : IRequestEngine<MovieRequests>
         Task<RequestEngineResult> ApproveMovie(MovieRequests request, bool is4K);
         Task<RequestEngineResult> ApproveMovieById(int requestId, bool is4K);
         Task<RequestEngineResult> DenyMovieById(int modelId, string denyReason, bool is4K);
-        Task<RequestsViewModel<MovieRequests>> GetRequests(int count, int position, string sortProperty, string sortOrder);
+        Task<RequestsViewModel<MovieRequests>> GetRequests(int count, int position, string sortProperty, string sortOrder, string requestedByUserId = null);
 
         Task<RequestsViewModel<MovieRequests>> GetUnavailableRequests(int count, int position, string sortProperty,
-            string sortOrder);
-        Task<RequestsViewModel<MovieRequests>> GetRequestsByStatus(int count, int position, string sortProperty, string sortOrder, RequestStatus status);
+            string sortOrder, string requestedByUserId = null);
+        Task<RequestsViewModel<MovieRequests>> GetRequestsByStatus(int count, int position, string sortProperty, string sortOrder, RequestStatus status, string requestedByUserId = null);
         Task<RequestEngineResult> UpdateAdvancedOptions(MediaAdvancedOptions options);
     }
 }

src/Ombi.Core/Engine/Interfaces/ITvRequestEngine.cs

@@ -9,7 +9,7 @@ namespace Ombi.Core.Engine.Interfaces
     public interface ITvRequestEngine : IRequestEngine<TvRequests>
     {
         Task<RequestsViewModel<ChildRequests>> GetUnavailableRequests(int count, int position, string sortProperty,
-            string sortOrder);
+            string sortOrder, string requestedByUserId = null);
         Task RemoveTvRequest(int requestId);
         Task<TvRequests> GetTvRequest(int requestId);
         Task<RequestEngineResult> RequestTvShow(TvRequestViewModel tv);
@@ -25,8 +25,8 @@ Task<RequestsViewModel<ChildRequests>> GetUnavailableRequests(int count, int pos
         Task<IEnumerable<TvRequests>> GetRequestsLite();
         Task UpdateQualityProfile(int requestId, int profileId);
         Task UpdateRootPath(int requestId, int rootPath);
-        Task<RequestsViewModel<ChildRequests>> GetRequests(int count, int position, string sortProperty, string sortOrder);
-         Task<RequestsViewModel<ChildRequests>> GetRequests(int count, int position, string sortProperty, string sortOrder, RequestStatus status);
+        Task<RequestsViewModel<ChildRequests>> GetRequests(int count, int position, string sortProperty, string sortOrder, string requestedByUserId = null);
+         Task<RequestsViewModel<ChildRequests>> GetRequests(int count, int position, string sortProperty, string sortOrder, RequestStatus status, string requestedByUserId = null);
         Task<RequestEngineResult> UpdateAdvancedOptions(MediaAdvancedOptions options);
     }
 }

src/Ombi.Core/Engine/MovieRequestEngine.cs

@@ -4,7 +4,6 @@
 using Ombi.Store.Entities;
 using System;
 using System.Collections.Generic;
-using System.ComponentModel;
 using System.Globalization;
 using System.Linq;
 using System.Security.Principal;
@@ -265,7 +264,7 @@ public async Task<RequestsViewModel<MovieRequests>> GetRequests(int count, int p
             };
         }
 
-        public async Task<RequestsViewModel<MovieRequests>> GetRequests(int count, int position, string sortProperty, string sortOrder)
+        public async Task<RequestsViewModel<MovieRequests>> GetRequests(int count, int position, string sortProperty, string sortOrder, string requestedByUserId = null)
         {
             var shouldHide = await HideFromOtherUsers();
             IQueryable<MovieRequests> allRequests;
@@ -282,24 +281,11 @@ public async Task<RequestsViewModel<MovieRequests>> GetRequests(int count, int p
                         .GetWithUser();
             }
 
-            var prop = TypeDescriptor.GetProperties(typeof(MovieRequests)).Find(sortProperty, true);
+            allRequests = FilterByRequestedUser(allRequests, requestedByUserId, shouldHide.IsAdmin);
 
-            if (sortProperty.Contains('.'))
-            {
-                // This is a navigation property currently not supported
-                prop = TypeDescriptor.GetProperties(typeof(MovieRequests)).Find("RequestedDate", true);
-                //var properties = sortProperty.Split(new []{'.'}, StringSplitOptions.RemoveEmptyEntries);
-                //var firstProp = TypeDescriptor.GetProperties(typeof(MovieRequests)).Find(properties[0], true);
-                //var propType = firstProp.PropertyType;
-                //var secondProp = TypeDescriptor.GetProperties(propType).Find(properties[1], true);
-            }
-
-            // TODO fix this so we execute this on the server
-            var requests = sortOrder.Equals("asc", StringComparison.InvariantCultureIgnoreCase)
-                ? allRequests.ToList().OrderBy(x => prop.GetValue(x)).ToList()
-                : allRequests.ToList().OrderByDescending(x => prop.GetValue(x)).ToList();
-            var total = requests.Count();
-            requests = requests.Skip(position).Take(count).ToList();
+            var total = await allRequests.CountAsync();
+            var requests = await ApplySortMovies(allRequests, sortProperty, sortOrder)
+                .Skip(position).Take(count).ToListAsync();
 
             await FillAdditionalFields(shouldHide, requests);
             return new RequestsViewModel<MovieRequests>
@@ -309,7 +295,7 @@ public async Task<RequestsViewModel<MovieRequests>> GetRequests(int count, int p
             };
         }
 
-        public async Task<RequestsViewModel<MovieRequests>> GetRequestsByStatus(int count, int position, string sortProperty, string sortOrder, RequestStatus status)
+        public async Task<RequestsViewModel<MovieRequests>> GetRequestsByStatus(int count, int position, string sortProperty, string sortOrder, RequestStatus status, string requestedByUserId = null)
         {
             var shouldHide = await HideFromOtherUsers();
             IQueryable<MovieRequests> allRequests;
@@ -326,6 +312,8 @@ public async Task<RequestsViewModel<MovieRequests>> GetRequestsByStatus(int coun
                         .GetWithUser();
             }
 
+            allRequests = FilterByRequestedUser(allRequests, requestedByUserId, shouldHide.IsAdmin);
+
             switch (status)
             {
                 case RequestStatus.PendingApproval:
@@ -356,8 +344,7 @@ public async Task<RequestsViewModel<MovieRequests>> GetRequestsByStatus(int coun
                     break;
             }
 
-            var requests = allRequests.ToList();
-            var total = requests.Count;
+            var total = await allRequests.CountAsync();
             if (total == 0)
             {
                 return new RequestsViewModel<MovieRequests>
@@ -367,24 +354,8 @@ public async Task<RequestsViewModel<MovieRequests>> GetRequestsByStatus(int coun
                 };
             }
 
-            var prop = TypeDescriptor.GetProperties(typeof(MovieRequests)).Find(sortProperty, true);
-
-            if (sortProperty.Contains('.'))
-            {
-                // This is a navigation property currently not supported
-                prop = TypeDescriptor.GetProperties(typeof(MovieRequests)).Find("RequestedDate", true);
-                //var properties = sortProperty.Split(new []{'.'}, StringSplitOptions.RemoveEmptyEntries);
-                //var firstProp = TypeDescriptor.GetProperties(typeof(MovieRequests)).Find(properties[0], true);
-                //var propType = firstProp.PropertyType;
-                //var secondProp = TypeDescriptor.GetProperties(propType).Find(properties[1], true);
-            }
-
-            requests = sortOrder.Equals("asc", StringComparison.InvariantCultureIgnoreCase)
-                ? allRequests.ToList().OrderBy(x => prop.GetValue(x)).ToList()
-                : allRequests.ToList().OrderByDescending(x => prop.GetValue(x)).ToList();
-
-            // TODO fix this so we execute this on the server
-            requests = requests.Skip(position).Take(count).ToList();
+            var requests = await ApplySortMovies(allRequests, sortProperty, sortOrder)
+                .Skip(position).Take(count).ToListAsync();
 
             await FillAdditionalFields(shouldHide, requests);
             return new RequestsViewModel<MovieRequests>
@@ -394,7 +365,7 @@ public async Task<RequestsViewModel<MovieRequests>> GetRequestsByStatus(int coun
             };
         }
 
-        public async Task<RequestsViewModel<MovieRequests>> GetUnavailableRequests(int count, int position, string sortProperty, string sortOrder)
+        public async Task<RequestsViewModel<MovieRequests>> GetUnavailableRequests(int count, int position, string sortProperty, string sortOrder, string requestedByUserId = null)
         {
             var shouldHide = await HideFromOtherUsers();
             IQueryable<MovieRequests> allRequests;
@@ -411,23 +382,11 @@ public async Task<RequestsViewModel<MovieRequests>> GetUnavailableRequests(int c
                         .GetWithUser().Where(x => !x.Available && x.Approved);
             }
 
-            var prop = TypeDescriptor.GetProperties(typeof(MovieRequests)).Find(sortProperty, true);
+            allRequests = FilterByRequestedUser(allRequests, requestedByUserId, shouldHide.IsAdmin);
 
-            if (sortProperty.Contains('.'))
-            {
-                // This is a navigation property currently not supported
-                prop = TypeDescriptor.GetProperties(typeof(MovieRequests)).Find("RequestedDate", true);
-                //var properties = sortProperty.Split(new []{'.'}, StringSplitOptions.RemoveEmptyEntries);
-                //var firstProp = TypeDescriptor.GetProperties(typeof(MovieRequests)).Find(properties[0], true);
-                //var propType = firstProp.PropertyType;
-                //var secondProp = TypeDescriptor.GetProperties(propType).Find(properties[1], true);
-            }
-
-            var requests = (sortOrder.Equals("asc", StringComparison.InvariantCultureIgnoreCase)
-                ? allRequests.ToList().OrderBy(x => prop.GetValue(x))
-                : allRequests.ToList().OrderByDescending(x => prop.GetValue(x))).ToList();
-            var total = requests.Count();
-            requests = requests.Skip(position).Take(count).ToList();
+            var total = await allRequests.CountAsync();
+            var requests = await ApplySortMovies(allRequests, sortProperty, sortOrder)
+                .Skip(position).Take(count).ToListAsync();
 
             await FillAdditionalFields(shouldHide, requests);
             return new RequestsViewModel<MovieRequests>
@@ -460,6 +419,18 @@ public async Task<RequestEngineResult> UpdateAdvancedOptions(MediaAdvancedOption
             };
         }
 
+        private static IQueryable<MovieRequests> ApplySortMovies(IQueryable<MovieRequests> query, string sortProperty, string sortOrder)
+        {
+            var asc = sortOrder.Equals("asc", StringComparison.InvariantCultureIgnoreCase);
+            return sortProperty.ToLowerInvariant() switch
+            {
+                "id" => asc ? query.OrderBy(x => x.Id) : query.OrderByDescending(x => x.Id),
+                "title" => asc ? query.OrderBy(x => x.Title) : query.OrderByDescending(x => x.Title),
+                "releasedate" => asc ? query.OrderBy(x => x.ReleaseDate) : query.OrderByDescending(x => x.ReleaseDate),
+                _ => asc ? query.OrderBy(x => x.RequestedDate) : query.OrderByDescending(x => x.RequestedDate)
+            };
+        }
+
         private IQueryable<MovieRequests> OrderMovies(IQueryable<MovieRequests> allRequests, OrderType type)
         {
             switch (type)