ci: release AppImage, pin appimagetool, drop JS eval in logs

LucHeart · LucHeart · commit fb03ad6a02ce · 2026-06-20T22:24:58.000+02:00
- Attach the AppImage artifact to draft releases in ci-tag.yml (it was built
  but never published).
- Pin appimagetool to 1.9.1 and verify its SHA256, instead of the unpinned
  'continuous' build, matching the action SHA-pinning policy.
- Replace the inline JS eval in LogsTab with a named openshock.scrollToBottom
  helper loaded from wwwroot/js/openshock.js.
diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml
@@ -235,9 +235,13 @@ jobs:
           ARCH=x86_64
           APPDIR=AppDir
 
-          # Download appimagetool (runs without FUSE via --appimage-extract-and-run)
+          # Download appimagetool, pinned to a tagged release and verified by checksum
+          # (runs without FUSE via --appimage-extract-and-run).
+          APPIMAGETOOL_VERSION=1.9.1
+          APPIMAGETOOL_SHA256=ed4ce84f0d9caff66f50bcca6ff6f35aae54ce8135408b3fa33abfc3cb384eb0
           curl -fsSL -o appimagetool \
-            "https://github.com/AppImage/appimagetool/releases/download/continuous/appimagetool-${ARCH}.AppImage"
+            "https://github.com/AppImage/appimagetool/releases/download/${APPIMAGETOOL_VERSION}/appimagetool-${ARCH}.AppImage"
+          echo "${APPIMAGETOOL_SHA256}  appimagetool" | sha256sum -c -
           chmod +x appimagetool
 
           # Assemble the AppDir from committed assets + the published self-contained app
diff --git a/.github/workflows/ci-tag.yml b/.github/workflows/ci-tag.yml
@@ -79,6 +79,12 @@ jobs:
           name: OpenShock Desktop Photino Linux
           path: artifacts/photino-linux/
 
+      - name: Download Linux AppImage
+        uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c  # v8.0.1
+        with:
+          name: OpenShock Desktop AppImage
+          path: artifacts/
+
       - name: Download Module Base
         uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c  # v8.0.1
         with:
@@ -100,4 +106,5 @@ jobs:
           files: |
             artifacts/OpenShock_Desktop_Setup.exe
             artifacts/OpenShock.Desktop.Photino.Linux.zip
+            artifacts/OpenShock_Desktop-*.AppImage
             artifacts/OpenShock.Desktop.Module.Base.zip
diff --git a/Desktop/Ui/Pages/Dash/Tabs/LogsTab.razor b/Desktop/Ui/Pages/Dash/Tabs/LogsTab.razor
@@ -104,7 +104,7 @@
             _shouldScroll = false;
             try
             {
-                await JS.InvokeVoidAsync("eval", "(()=>{var e=document.getElementById('console-body');if(e)e.scrollTop=e.scrollHeight;})()");
+                await JS.InvokeVoidAsync("openshock.scrollToBottom", "console-body");
             }
             catch { /* ignore */ }
         }
diff --git a/Desktop/wwwroot/index.html b/Desktop/wwwroot/index.html
@@ -11,6 +11,7 @@
     <link href="_content/MudBlazor/MudBlazor.min.css" rel="stylesheet"/>
     <script src="_content/MudBlazor/MudBlazor.min.js"></script>
     <script src="js/tailwindcss-browser.js"></script>
+    <script src="js/openshock.js"></script>
 </head>
 
 <body>
diff --git a/Desktop/wwwroot/js/openshock.js b/Desktop/wwwroot/js/openshock.js
@@ -0,0 +1,9 @@
+// Small JS interop helpers for OpenShock Desktop.
+window.openshock = window.openshock || {};
+
+// Scrolls the element with the given id to the bottom. Used by the logs console
+// for autoscroll. No-op if the element is not present.
+window.openshock.scrollToBottom = function (elementId) {
+    const el = document.getElementById(elementId);
+    if (el) el.scrollTop = el.scrollHeight;
+};
diff --git a/Desktop/wwwroot/photino.html b/Desktop/wwwroot/photino.html
@@ -11,6 +11,7 @@
     <link href="_content/MudBlazor/MudBlazor.min.css" rel="stylesheet"/>
     <script src="_content/MudBlazor/MudBlazor.min.js"></script>
     <script src="js/tailwindcss-browser.js"></script>
+    <script src="js/openshock.js"></script>
 </head>
 
 <body>

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@`
`104`	`104`	`_shouldScroll = false;`
`105`	`105`	`try`
`106`	`106`	`{`
`107`		`- await JS.InvokeVoidAsync("eval", "(()=>{var e=document.getElementById('console-body');if(e)e.scrollTop=e.scrollHeight;})()");`
	`107`	`+ await JS.InvokeVoidAsync("openshock.scrollToBottom", "console-body");`
`108`	`108`	`}`
`109`	`109`	`catch { /* ignore */ }`
`110`	`110`	`}`