Remove superfluous methods

Note that the spy should have been failing, but it was never checked.

Refs #3188

Author: thewilkybarkid

src/Prereviewers/index.ts

@@ -1,10 +1,7 @@
-import { FetchHttpClient } from '@effect/platform'
-import { Context, Effect, Layer, pipe, Redacted } from 'effect'
+import { Context, Effect, Layer, pipe } from 'effect'
 import * as Commands from '../Commands.ts'
 import { UnableToHandleCommand } from '../Commands.ts'
-import * as LegacyPrereview from '../legacy-prereview.ts'
 import * as Queries from '../Queries.ts'
-import { FptsToEffect } from '../RefactoringUtilities/index.ts'
 import { Temporal, type OrcidId } from '../types/index.ts'
 import { possiblePseudonyms } from '../types/Pseudonym.ts'
 import { GetAvailablePseudonym } from './GetAvailablePseudonym.ts'
@@ -17,14 +14,10 @@ import { RegisterPrereviewer } from './RegisterPrereviewer.ts'
 export class Prereviewers extends Context.Tag('Prereviewers')<
   Prereviewers,
   {
-    legacyRegister: (orcidId: OrcidId.OrcidId) => Effect.Effect<void, UnableToHandleCommand>
     register: (orcidId: OrcidId.OrcidId) => Effect.Effect<void, UnableToHandleCommand>
     isRegistered: Queries.FromOnDemandQuery<typeof IsRegistered>
     getPseudonym: Queries.FromOnDemandQuery<typeof GetPseudonym>
     listAllPrereviewersForStats: Queries.FromStatefulQuery<typeof ListAllPrereviewersForStats>
-    importRegisteredOrcidId: (
-      orcidId: OrcidId.OrcidId,
-    ) => ReturnType<Commands.FromCommand<typeof ImportRegisteredPrereviewer>>
     importRegisteredPrereviewer: Commands.FromCommand<typeof ImportRegisteredPrereviewer>
   }
 >() {}
@@ -34,9 +27,6 @@ export const { listAllPrereviewersForStats } = Effect.serviceFunctions(Prereview
 export const layer = Layer.effect(
   Prereviewers,
   Effect.gen(function* () {
-    const fetch = yield* FetchHttpClient.Fetch
-    const legacyPrereviewApi = yield* LegacyPrereview.LegacyPrereviewApi
-
     const importRegisteredPrereviewer = yield* Commands.makeCommand(ImportRegisteredPrereviewer)
     const registerPrereviewer = yield* Commands.makeCommand(RegisterPrereviewer)
 
@@ -47,19 +37,6 @@ export const layer = Layer.effect(
     )
 
     return {
-      legacyRegister: orcid =>
-        pipe(
-          FptsToEffect.readerTaskEither(LegacyPrereview.createUserOnLegacyPrereview({ name: orcid, orcid }), {
-            fetch,
-            legacyPrereviewApi: {
-              app: legacyPrereviewApi.app,
-              key: Redacted.value(legacyPrereviewApi.key),
-              url: legacyPrereviewApi.origin,
-            },
-          }),
-          Effect.asVoid,
-          Effect.mapError(() => new UnableToHandleCommand({ cause: 'Legacy user API unavailable' })),
-        ),
       register: Effect.fn('Prereviewers.register')(
         function* (orcidId) {
           const prereviewer = {
@@ -80,21 +57,6 @@ export const layer = Layer.effect(
       isRegistered: yield* Queries.makeOnDemandQuery(IsRegistered),
       getPseudonym: yield* Queries.makeOnDemandQuery(GetPseudonym),
       listAllPrereviewersForStats: yield* Queries.makeStatefulQuery(ListAllPrereviewersForStats),
-      importRegisteredOrcidId: orcid =>
-        pipe(
-          FptsToEffect.readerTaskEither(LegacyPrereview.getUserFromLegacyPrereview(orcid), {
-            fetch,
-            legacyPrereviewApi: {
-              app: legacyPrereviewApi.app,
-              key: Redacted.value(legacyPrereviewApi.key),
-              url: legacyPrereviewApi.origin,
-            },
-          }),
-          Effect.mapError(() => new UnableToHandleCommand({ cause: 'Legacy user API unavailable' })),
-          Effect.andThen(({ pseudonym, createdAt }) =>
-            importRegisteredPrereviewer({ orcidId: orcid, pseudonym, registeredAt: createdAt }),
-          ),
-        ),
       importRegisteredPrereviewer,
     }
   }),

test/WebApp/log-in/log-in.test.ts

@@ -244,9 +244,6 @@ describe('authenticate', () => {
       'when the PREreviewer has not been registered',
       (code, [publicUrl, state], orcidOauth, locale, accessToken, sessionCookie, sessionId, signedSessionId) => {
         const registerSpy = jest.fn<(typeof Prereviewers.Service)['register']>(() => Effect.void)
-        const importRegisteredOrcidIdSpy = jest.fn<(typeof Prereviewers.Service)['importRegisteredOrcidId']>(
-          () => Effect.void,
-        )
 
         return Effect.gen(function* () {
           yield* _.authenticate(code, state)
@@ -268,7 +265,6 @@ describe('authenticate', () => {
             Layer.mock(Prereviewers, {
               isRegistered: () => Effect.succeed(false),
               register: registerSpy,
-              importRegisteredOrcidId: importRegisteredOrcidIdSpy,
             }),
             Layer.succeed(PublicUrl, publicUrl),
             Layer.succeed(SessionStore, { cookie: sessionCookie, store: new Keyv() }),