Skip to content

Commit 32b3cb2

Browse files
committed
bugfix: make sure collage limit is always defined
Change-Id: I19c98a06a67c8746a0efddcd7a8e449e50e051fa
1 parent 3f38cb7 commit 32b3cb2

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

api/admin.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,7 @@
255255
}
256256

257257
// Collage json config
258+
$newConfig['collage']['limit'] = $newConfig['collage']['limit'] ?? $defaultConfig['collage']['limit'];
258259
if ($newConfig['collage']['enabled']) {
259260
$collageConfigFilePath = Collage::getCollageConfigPath($newConfig['collage']['layout'], $newConfig['collage']['orientation']);
260261

@@ -307,6 +308,7 @@
307308
}
308309
if ($newConfig['collage']['limit'] < 1) {
309310
$newConfig['collage']['enabled'] = false;
311+
$newConfig['collage']['limit'] = $defaultConfig['collage']['limit'];
310312
$logger->debug('Invalid collage limit, must be 1 or greater. Collage disabled.');
311313
}
312314
}

src/Configuration/Section/CollageConfiguration.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,15 @@ public static function getNode(): NodeDefinition
4949
})
5050
->end()
5151
->end()
52+
->integerNode('limit')
53+
->defaultValue(4)
54+
->min(1)
55+
->max(999)
56+
->beforeNormalization()
57+
->ifString()
58+
->then(function (string $value): int { return intval($value); })
59+
->end()
60+
->end()
5261
->scalarNode('dashedline_color')->defaultValue('#000000')->end()
5362
->booleanNode('keep_single_images')->defaultValue(false)->end()
5463
->scalarNode('key')

0 commit comments

Comments
 (0)