Skip to content

Commit 64dd055

Browse files
committed
admin: disabled collage if layout not found
1 parent e652d5b commit 64dd055

File tree

1 file changed

+19
-16
lines changed

1 file changed

+19
-16
lines changed

api/admin.php

Lines changed: 19 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -277,29 +277,32 @@
277277
} else {
278278
$layoutConfigArray = $collageJson;
279279
}
280+
281+
// Calculate collage limit
280282
if (str_starts_with($newConfig['collage']['layout'], '2x')) {
281283
$newConfig['collage']['limit'] = (int) ceil(count($layoutConfigArray) / 2);
282284
} else {
283285
$newConfig['collage']['limit'] = count($layoutConfigArray);
284286
}
285-
} else {
286-
// To-Do: Define defaults and log error?
287-
}
288-
}
289287

290-
// If there is a collage placeholder whithin the correct range (0 < placeholderposition <= collage limit), we need to decrease the collage limit by 1
291-
if ($newConfig['collage']['placeholder']) {
292-
$collagePlaceholderPosition = (int) $newConfig['collage']['placeholderposition'];
293-
if ($collagePlaceholderPosition > 0 && $collagePlaceholderPosition <= $newConfig['collage']['limit']) {
294-
$newConfig['collage']['limit'] = $newConfig['collage']['limit'] - 1;
295-
} else {
296-
$newConfig['collage']['placeholder'] = false;
297-
$logger->debug('Placeholder position not in range. Placeholder disabled.');
298-
}
288+
// If there is a collage placeholder whithin the correct range (0 < placeholderposition <= collage limit), we need to decrease the collage limit by 1
289+
if ($newConfig['collage']['placeholder']) {
290+
$collagePlaceholderPosition = (int) $newConfig['collage']['placeholderposition'];
291+
if ($collagePlaceholderPosition > 0 && $collagePlaceholderPosition <= $newConfig['collage']['limit']) {
292+
$newConfig['collage']['limit'] = $newConfig['collage']['limit'] - 1;
293+
} else {
294+
$newConfig['collage']['placeholder'] = false;
295+
$logger->debug('Placeholder position not in range. Placeholder disabled.');
296+
}
299297

300-
if ($newConfig['collage']['placeholderpath'] === '') {
301-
$newConfig['collage']['placeholder'] = false;
302-
$logger->debug('Collage Placeholder is empty. Collage Placeholder disabled.');
298+
if ($newConfig['collage']['placeholderpath'] === '') {
299+
$newConfig['collage']['placeholder'] = false;
300+
$logger->debug('Collage Placeholder is empty. Collage Placeholder disabled.');
301+
}
302+
}
303+
} else {
304+
$newConfig['collage']['enabled'] = false;
305+
$logger->debug('No valid collage json found. Collage disabled.');
303306
}
304307
}
305308
}

0 commit comments

Comments
 (0)