initial config would rotate by 0 degree, resulting in a black image

Change-Id: Ia639c1f188b9174a3accb343bafc2e6eb6de9a81

Author: reloxx13

api/applyEffects.php

@@ -150,18 +150,18 @@
                     }
                 }
 
-                if ($config['picture']['rotation'] !== '0') {
+                if ((int)$config['picture']['rotation'] !== 0) {
                     $imageResource = $imageHandler->rotateResizeImage(
                         image: $imageResource,
-                        degrees: $config['picture']['rotation']
+                        degrees: (int)$config['picture']['rotation'],
                     );
                     if (!$imageResource instanceof \GdImage) {
                         throw new \Exception('Error resizing resource.');
                     }
                 }
 
                 // Apply rembg
-                list($imageHandler, $imageResource) = Rembg::process($imageHandler, $vars, $config['rembg'], $imageResource);
+                [$imageHandler, $imageResource] = Rembg::process($imageHandler, $vars, $config['rembg'], $imageResource);
                 if ($config['picture']['polaroid_effect']) {
                     $imageHandler->polaroidRotation = $config['picture']['polaroid_rotation'];
                     $imageResource = $imageHandler->effectPolaroid($imageResource);

api/chromakeying/save.php

@@ -121,10 +121,10 @@
             }
         }
 
-        if ($config['picture']['rotation'] !== '0') {
+        if ((int)$config['picture']['rotation'] !== 0) {
             $imageResource = $imageHandler->rotateResizeImage(
                 image: $imageResource,
-                degrees: $config['picture']['rotation']
+                degrees: (int)$config['picture']['rotation'],
             );
             if (!$imageResource instanceof \GdImage) {
                 throw new \Exception('Error resizing resource.');

src/Image.php

@@ -438,6 +438,11 @@ public function saveJpeg(GdImage $sourceResource, string $destination): bool
      */
     public function rotateResizeImage(GdImage $image, int $degrees, string $bgColor = '#ffffff', bool $useTransparentBackground = false): GdImage|false
     {
+        if ($degrees % 360 === 0) {
+            // No rotation needed for 0, 360, -360, etc.
+            return $image;
+        }
+
         $new = $image;
         try {
             // simple rotate if possible and ignore changed dimensions (doesn't need to care about background color)
@@ -447,6 +452,8 @@ public function rotateResizeImage(GdImage $image, int $degrees, string $bgColor
                 if (!$new) {
                     throw new \Exception('Cannot rotate image.');
                 }
+                // without, 0 degree rotation would loose alpha blending, results in black image
+                imagealphablending($new, true);
             } else {
                 $old_width = imagesx($image);
                 $old_height = imagesy($image);
@@ -465,7 +472,7 @@ public function rotateResizeImage(GdImage $image, int $degrees, string $bgColor
                     $background = imagecolorallocatealpha($new, 0, 0, 0, 127);
                 } else {
                     $colorComponents = self::getColorComponents($bgColor);
-                    list($bg_r, $bg_g, $bg_b, $bg_a) = $colorComponents;
+                    [$bg_r, $bg_g, $bg_b, $bg_a] = $colorComponents;
                     // color background as defined
                     $background = imagecolorallocatealpha($new, $bg_r, $bg_g, $bg_b, $bg_a);
                 }

test/photo.php

@@ -42,9 +42,9 @@
     }
     if (class_exists('Photobooth\Processor\ImageProcessor')) {
         $processor = new ImageProcessor($imageHandler, $logger, $database, $vars, $config);
-    }
-    if ($processor !== null && $processor instanceof ImageProcessor && method_exists($processor, 'preImageProcessing')) {
-        [$imageHandler, $vars, $config, $imageResource] = $processor->preImageProcessing($imageHandler, $vars, $config, $imageResource);
+        if (method_exists($processor, 'preImageProcessing')) {
+            [$imageHandler, $vars, $config, $imageResource] = $processor->preImageProcessing($imageHandler, $vars, $config, $imageResource);
+        }
     }
     $imageHandler->framePath = PathUtility::getPublicPath($config['picture']['frame']);
 
@@ -73,10 +73,10 @@
         }
     }
 
-    if ($config['picture']['rotation'] !== '0') {
+    if ((int)$config['picture']['rotation'] !== 0) {
         $imageResource = $imageHandler->rotateResizeImage(
             image: $imageResource,
-            degrees: $config['picture']['rotation']
+            degrees: (int)$config['picture']['rotation'],
         );
         if (!$imageResource) {
             throw new \Exception('Error resizing resource.');