Skip to content

Commit af9abb0

Browse files
PhotoboothPhotobooth
authored andcommitted
fix: prevent UI from hanging on unexpected errors during capture flow
Add comprehensive try/catch error handling to all critical paths in the photo capture flow. Previously, only .fail() callbacks had error handling while .done() callbacks and other functions could silently crash, leaving the UI stuck on the loader screen with takingPic=true. Changes: - Wrap errorPic cleanup in try/catch so page reload always fires - Add fallback timeout (5s) if notificationTimeout is NaN - Add try/catch to thrill(), takePic(), callTakePicApi .done(), callTakeVideoApi .done(), processPic success, processVideo success - Add missing timeout (25s) to callTakeVideoApi jQuery post
1 parent 68c3579 commit af9abb0

File tree

3 files changed

+376
-321
lines changed

3 files changed

+376
-321
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ on:
66
branches:
77
- dev
88
- stable4
9+
- fix/**
10+
- feature/**
911
pull_request:
1012
branches:
1113
- dev

.github/workflows/linters.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ on:
55
push:
66
branches:
77
- dev
8+
- fix/**
9+
- feature/**
810
pull_request:
911
branches:
1012
- dev

0 commit comments

Comments
 (0)