Skip to content

[lit-next] Ensure nested directives handle noChange as expected  #1519

@sorvell

Description

@sorvell

When a directive returns noChange any nested directive value it might otherwise return should be unchanged. Currently, the resolveDirective helper does not handle noChange and treats this as a value that should clear the nested directive. The nested directive gets removed and then re-created if it is subsequently returned. This prevents, for example, the guard directive from being able to guard a nested directive from running.

To address this, resolveDirective can special case noChange to bail early and simply not process any nested directives.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions