lol (#1170)

Author: zzstoatzz

examples/slackbot/src/slackbot/core.py

@@ -21,7 +21,11 @@
 
 from slackbot.assets import store_user_facts
 from slackbot.research_agent import research_prefect_topic
-from slackbot.search import read_github_issues
+from slackbot.search import (
+    display_callable_signature,
+    explore_module_offerings,
+    read_github_issues,
+)
 from slackbot.settings import settings
 from slackbot.types import UserContext
 
@@ -49,6 +53,7 @@
 1.  **For Technical/Conceptual Questions:** Use `research_prefect_topic`. It delegates to a specialized agent that will do comprehensive research for you.
 2.  **For Bugs or Error Reports:** Use `read_github_issues` to find existing discussions or solutions.
 3.  **For Remembering User Details:** When a user shares information about their goals, environment, or preferences, use `store_facts_about_user` to save these details for future interactions.
+4. **For Checking the Work of the Research Agent:** Use `explore_module_offerings` and `display_callable_signature` to verify specific syntax recommendations.
 """
 
 
@@ -173,12 +178,16 @@ def create_agent(
             api_key=Secret.load(settings.anthropic_key_secret_name, _sync=True).get(),  # type: ignore
         ),
     )
-    agent = Agent[UserContext, str](
+    agent = Agent[
+        UserContext, str
+    ](
         model=ai_model,
         model_settings=ModelSettings(temperature=settings.temperature),
         tools=[
             research_prefect_topic,  # Main tool for researching Prefect topics
             read_github_issues,  # For searching GitHub issues
+            explore_module_offerings,  # check the work of the research agent, verify imports, types functions
+            display_callable_signature,  # check the work of the research agent, verify signatures of callable objects
         ],
         deps_type=UserContext,
     )

examples/slackbot/src/slackbot/github.py

@@ -0,0 +1,64 @@
+import os
+from datetime import datetime
+from typing import Optional
+
+from pydantic import BaseModel, Field
+
+import marvin
+from marvin.utilities.logging import get_logger
+
+
+async def _get_token() -> str:
+    try:
+        from prefect.blocks.system import Secret
+
+        return (await Secret.aload(name="github-token")).get()
+    except (ImportError, ValueError) as exc:
+        getattr(get_logger("marvin"), "debug_kv")(
+            (
+                "Prefect Secret for GitHub token not retrieved. "
+                f"{exc.__class__.__name__}: {exc}"
+                "red"
+            ),
+        )
+
+    try:
+        return getattr(marvin.settings, "github_token")
+    except AttributeError:
+        pass
+
+    if token := os.environ.get("MARVIN_GITHUB_TOKEN", ""):
+        return token
+
+    raise RuntimeError("GitHub token not found")
+
+
+class GitHubUser(BaseModel):
+    """GitHub user."""
+
+    login: Optional[str] = None
+
+
+class GitHubComment(BaseModel):
+    """GitHub comment."""
+
+    body: str = Field(default="")
+    user: GitHubUser = Field(default_factory=GitHubUser)
+
+
+class GitHubLabel(BaseModel):
+    """GitHub label."""
+
+    name: str = Field(default="")
+
+
+class GitHubIssue(BaseModel):
+    """GitHub issue."""
+
+    created_at: datetime = Field(...)
+    html_url: str = Field(...)
+    number: int = Field(...)
+    title: str = Field(default="")
+    body: str = Field(default="")
+    labels: list[GitHubLabel] = Field(default_factory=GitHubLabel)
+    user: GitHubUser = Field(default_factory=GitHubUser)

examples/slackbot/src/slackbot/research_agent.py

@@ -52,14 +52,15 @@ def create_research_agent(
 Your research process:
 1. Start with broad documentation searches to understand the topic context
 2. Use multiple search queries with different keywords - don't stop at first result
-3. Use explore_module_offerings to understand what's available in relevant modules
+3. Use explore_module_offerings to understand what's available in relevant modules (i.e. valid imports, types and functions available)
 4. Use display_callable_signature to get detailed signatures of functions, classes, and methods when needed
 5. Focus on Prefect 3.x documentation unless explicitly asked about 2.x or older versions
 6. Review gotchas and release notes for recent changes
 
 Remember: You are the research specialist. The main agent relies on you for accurate, comprehensive information.
 Be thorough - use tools repeatedly until you have complete information.
 Default to Prefect 3.x unless the user explicitly asks about 2.x or version compatibility.
+Do not use any Prefect syntax you have not gathered empirically.
 """,
         tools=[
             get_latest_prefect_release_notes,

examples/slackbot/src/slackbot/search.py

@@ -1,19 +1,14 @@
 import asyncio
-import os
-from datetime import datetime
-from typing import Optional
 
 import httpx
 import turbopuffer as tpuf
 from prefect import task
 from prefect.blocks.system import Secret
 from pretty_mod import display_signature
 from pretty_mod.explorer import ModuleTreeExplorer
-from pydantic import BaseModel, Field, field_validator
 from raggy.vectorstores.tpuf import multi_query_tpuf
 
-import marvin
-from marvin.utilities.logging import get_logger
+from slackbot.github import GitHubIssue, _get_token
 from slackbot.settings import settings
 from slackbot.strings import slice_tokens
 
@@ -60,6 +55,7 @@ def review_common_3x_gotchas() -> list[str]:
         "futures returned by .map can be resolved together, like integers = double.map(range(10)).result()",
         "futures must be resolved by passing them to another task, returning them or manually calling .result() or .wait()",
         "agents are replaced by workers in prefect 3.x, work pools replace the infra blocks from prefect.infrastructure",
+        "the `prefect.infrastructure` IS COMPLETELY REMOVED IN 3.x, see work pools instead",
         "prefect 3.x uses pydantic 2 and server data from prefect 2.x is not compatible with 3.x",
         "Deployment.build_from_flow() IS COMPLETELY REMOVED IN 3.x, use some_flow.from_source(...).deploy(...) instead.",
         "`prefect deployment build ...`  IS COMPLETELY REMOVED IN 3.x, use `prefect deploy ...` instead",
@@ -133,68 +129,6 @@ def get_latest_prefect_release_notes() -> str:
         return release_notes
 
 
-async def _get_token() -> str:
-    try:
-        from prefect.blocks.system import Secret
-
-        return (await Secret.aload(name="github-token")).get()
-    except (ImportError, ValueError) as exc:
-        getattr(get_logger("marvin"), "debug_kv")(
-            (
-                "Prefect Secret for GitHub token not retrieved. "
-                f"{exc.__class__.__name__}: {exc}"
-                "red"
-            ),
-        )
-
-    try:
-        return getattr(marvin.settings, "github_token")
-    except AttributeError:
-        pass
-
-    if token := os.environ.get("MARVIN_GITHUB_TOKEN", ""):
-        return token
-
-    raise RuntimeError("GitHub token not found")
-
-
-class GitHubUser(BaseModel):
-    """GitHub user."""
-
-    login: Optional[str] = None
-
-
-class GitHubComment(BaseModel):
-    """GitHub comment."""
-
-    body: str = Field(default="")
-    user: GitHubUser = Field(default_factory=GitHubUser)
-
-
-class GitHubLabel(BaseModel):
-    """GitHub label."""
-
-    name: str = Field(default="")
-
-
-class GitHubIssue(BaseModel):
-    """GitHub issue."""
-
-    created_at: datetime = Field(...)
-    html_url: str = Field(...)
-    number: int = Field(...)
-    title: str = Field(default="")
-    body: str | None = Field(default="")
-    labels: list[GitHubLabel] = Field(default_factory=GitHubLabel)
-    user: GitHubUser = Field(default_factory=GitHubUser)
-
-    @field_validator("body")
-    def validate_body(cls, v: str) -> str:
-        if not v:
-            return ""
-        return v
-
-
 @task(task_run_name="Reading {n} issues from {repo} given query: {query}")
 def read_github_issues(query: str, repo: str = "prefecthq/prefect", n: int = 3) -> str:
     """
@@ -207,7 +141,6 @@ def read_github_issues(query: str, repo: str = "prefecthq/prefect", n: int = 3)
         - repo: prefecthq/prefect
         - query: label:bug is:open AttributeError
     """
-    # Load GitHub token synchronously
     github_token = Secret.load(settings.github_token_secret_name, _sync=True).get()  # type: ignore
     return asyncio.run(
         search_github_issues(query, repo=repo, n=n, api_token=github_token)
@@ -230,6 +163,7 @@ async def search_github_issues(
         - repo: prefecthq/prefect
         - query: label:bug is:open AttributeError
     """
+    TOKEN_LIMIT = 1500
     headers = {"Accept": "application/vnd.github.v3+json"}
 
     headers["Authorization"] = f"Bearer {api_token or await _get_token()}"
@@ -248,11 +182,10 @@ async def search_github_issues(
 
     issues_data = response.json()["items"]
 
-    # enforce 1000 token limit per body
     for issue in issues_data:
         if not issue["body"]:
             continue
-        issue["body"] = slice_tokens(issue["body"], 1000)
+        issue["body"] = slice_tokens(issue["body"], TOKEN_LIMIT)
 
     issues = [GitHubIssue(**issue) for issue in issues_data]