fix: self-review dead code and alert binding fixes

- Remove unused @State currentSession in RetroAchievementsView
- Simplify initializeClient: remove unnecessary nested Task inside MainActor.run
- Remove dead moveTVOSBackup(from:) in BackupRestoreView (never called)
- Fix .constant(errorMessage != nil) anti-pattern in BatchArtworkMatchingView
  with proper @State showErrorAlert so the alert can dismiss correctly

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: github-actions[bot]

PVUI/Sources/PVSwiftUI/Settings/RetroAchievementsView.swift

@@ -21,7 +21,6 @@ public struct RetroAchievementsView: View {
     @State private var loadingProgress: Double = 0
     @State private var errorMessage: String?
     @State private var showingError = false
-    @State private var currentSession: RAUserSession?
     @State private var userProfile: RAUserProfile?
     @State private var isAuthenticated = false
 
@@ -574,31 +573,21 @@ public struct RetroAchievementsView: View {
         }
     }
 
+    @MainActor
     private func initializeClient() async {
         // Create client and check for existing session
         client = PVCheevos.client()
 
-        await MainActor.run {
-            // Check if already authenticated
-            if let currentClient = client {
-                Task {
-                    let authenticated = await currentClient.isAuthenticated
-
-                    await MainActor.run {
-                        isAuthenticated = authenticated
-                        if authenticated {
-                            // Load stored profile or create basic one
-                            if let storedProfile = RetroCredentialsManager.shared.loadUserProfile() {
-                                userProfile = storedProfile
-                            }
-                        }
+        guard let currentClient = client else { return }
 
-                        // Load RetroArch settings
-                        loadRetroArchSettings()
-                    }
-                }
+        let authenticated = currentClient.isAuthenticated
+        isAuthenticated = authenticated
+        if authenticated {
+            if let storedProfile = RetroCredentialsManager.shared.loadUserProfile() {
+                userProfile = storedProfile
             }
         }
+        loadRetroArchSettings()
     }
 
     private func loadRetroArchSettings() {

PVUI/Sources/PVSwiftUI/Settings/Views/BackupRestoreView.swift

@@ -358,21 +358,6 @@ struct BackupRestoreView: View {
     }
 
     #if os(tvOS)
-    private func moveTVOSBackup(from tempURL: URL) {
-        let dest = URL.documentsPath.appendingPathComponent(tempURL.lastPathComponent)
-        do {
-            if FileManager.default.fileExists(atPath: dest.path) {
-                try FileManager.default.removeItem(at: dest)
-            }
-            try FileManager.default.moveItem(at: tempURL, to: dest)
-            alertMessage = "Backup saved to Documents: \(dest.lastPathComponent)"
-            showAlert = true
-        } catch {
-            // State update handled via coordinator.backupState observer
-            ELOG("BackupRestoreView: could not move tvOS backup: \(error)")
-        }
-    }
-
     private func startTVOSRestore() {
         let docs = URL.documentsPath
         let fm = FileManager.default

PVUI/Sources/PVSwiftUI/Settings/Views/BatchArtworkMatchingView.swift

@@ -49,6 +49,7 @@ public struct BatchArtworkMatchingView: View {
     @State private var searchProgress: Double = 0
     @State private var currentSearchTitle: String = ""
     @State private var errorMessage: String?
+    @State private var showErrorAlert = false
 
     // Game and artwork data
     @State private var gamesNeedingArtwork: [PVGame] = []
@@ -134,10 +135,11 @@ public struct BatchArtworkMatchingView: View {
         .uiKitAlert(
             "Error",
             message: errorMessage ?? "",
-            isPresented: .constant(errorMessage != nil),
+            isPresented: $showErrorAlert,
             preferredContentSize: CGSize(width: 500, height: 300)
         ) {
             UIAlertAction(title: "OK", style: .default) { _ in
+                showErrorAlert = false
                 errorMessage = nil
             }
         }
@@ -513,6 +515,7 @@ public struct BatchArtworkMatchingView: View {
         } catch {
             ELOG("Error loading games: \(error)")
             errorMessage = "Error loading games: \(error.localizedDescription)"
+            showErrorAlert = true
         }
     }
 
@@ -582,6 +585,7 @@ public struct BatchArtworkMatchingView: View {
         } catch {
             ELOG("Error searching for artwork: \(error)")
             errorMessage = "Error searching for artwork: \(error.localizedDescription)"
+            showErrorAlert = true
             if clearExisting {
                 // Show partial failure info from an interrupted initial scan.
                 failedGames = newFailures
@@ -671,6 +675,7 @@ public struct BatchArtworkMatchingView: View {
         } catch {
             ELOG("Error applying artwork: \(error)")
             errorMessage = "Error applying artwork: \(error.localizedDescription)"
+            showErrorAlert = true
         }
     }
 }