fix: self-review — remove duplicate types, dead code, deprecated APIs

- Remove duplicate ShareSheet definition (already in ShareSheet.swift),
  which caused an "Invalid redeclaration" compile error
- Remove duplicate RetroToggleStyle struct; use RetroTheme.RetroToggleStyle()
- Drop unused currentUser variable and unused scanlineOffset @State var
- Fix deprecated onChange(of:) single-param closures to two-param form (iOS 17)
- Remove redundant @available(iOS 15.0,...) annotation (min target is iOS 17)
- Add missing .foregroundColor(.white) on Refresh button in BatchArtworkMatchingView

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: github-actions[bot]

PVUI/Sources/PVSwiftUI/Settings/RetroAchievementsView.swift

@@ -4,7 +4,6 @@ import PVCheevos
 import Combine
 
 /// RetroAchievements login and profile view with RetroWave styling
-@available(iOS 15.0, tvOS 15.0, macOS 12.0, *)
 public struct RetroAchievementsView: View {
     // MARK: - Configuration
 
@@ -584,7 +583,6 @@ public struct RetroAchievementsView: View {
             if let currentClient = client {
                 Task {
                     let authenticated = await currentClient.isAuthenticated
-                    let currentUser = await currentClient.currentUsername
 
                     await MainActor.run {
                         isAuthenticated = authenticated
@@ -744,8 +742,8 @@ public struct RetroAchievementsView: View {
                     Spacer()
 
                     Toggle("", isOn: $retroAchievementsEnabled)
-                        .toggleStyle(RetroToggleStyle())
-                        .onChange(of: retroAchievementsEnabled) { newValue in
+                        .toggleStyle(RetroTheme.RetroToggleStyle())
+                        .onChange(of: retroAchievementsEnabled) { _, newValue in
                             PVCheevos.retroArch.isRetroAchievementsEnabled = newValue
                         }
                 }
@@ -766,8 +764,8 @@ public struct RetroAchievementsView: View {
                     Spacer()
 
                     Toggle("", isOn: $hardcoreModeEnabled)
-                        .toggleStyle(RetroToggleStyle())
-                        .onChange(of: hardcoreModeEnabled) { newValue in
+                        .toggleStyle(RetroTheme.RetroToggleStyle())
+                        .onChange(of: hardcoreModeEnabled) { _, newValue in
                             PVCheevos.retroArch.isHardcoreModeEnabled = newValue
                         }
                 }
@@ -785,65 +783,6 @@ public struct RetroAchievementsView: View {
     }
 }
 
-// MARK: - Custom Toggle Style
-
-struct RetroToggleStyle: ToggleStyle {
-    func makeBody(configuration: Configuration) -> some View {
-        HStack {
-            configuration.label
-            Spacer()
-            toggleSwitch(isOn: configuration.isOn) {
-                configuration.isOn.toggle()
-            }
-        }
-    }
-
-    @ViewBuilder
-    private func toggleSwitch(isOn: Bool, action: @escaping () -> Void) -> some View {
-        Button(action: action) {
-            toggleBackground(isOn: isOn)
-                .overlay(toggleThumb(isOn: isOn))
-                .frame(width: 50, height: 30)
-        }
-        .buttonStyle(.plain)
-    }
-
-    @ViewBuilder
-    private func toggleBackground(isOn: Bool) -> some View {
-        RoundedRectangle(cornerRadius: 16)
-            .fill(backgroundFill(isOn: isOn))
-            .overlay(backgroundBorder(isOn: isOn))
-            .animation(.spring(response: 0.3, dampingFraction: 0.7), value: isOn)
-    }
-
-    @ViewBuilder
-    private func toggleThumb(isOn: Bool) -> some View {
-        Circle()
-            .fill(Color.white)
-            .frame(width: 26, height: 26)
-            .offset(x: isOn ? 10 : -10)
-            .shadow(color: .black.opacity(0.2), radius: 2, x: 0, y: 1)
-            .animation(.spring(response: 0.3, dampingFraction: 0.7), value: isOn)
-    }
-
-    private func backgroundFill(isOn: Bool) -> AnyShapeStyle {
-        if isOn {
-            return AnyShapeStyle(RetroTheme.retroHorizontalGradient)
-        } else {
-            return AnyShapeStyle(Color.black.opacity(0.6))
-        }
-    }
-
-    @ViewBuilder
-    private func backgroundBorder(isOn: Bool) -> some View {
-        RoundedRectangle(cornerRadius: 16)
-            .strokeBorder(
-                isOn ? Color.clear : Color.white.opacity(0.3),
-                lineWidth: 1
-            )
-    }
-}
-
 // MARK: - Supporting Types
 
 enum LoginError: LocalizedError {
@@ -863,15 +802,3 @@ enum LoginError: LocalizedError {
     }
 }
 
-#if !os(tvOS)
-/// Share sheet for tvOS compatibility
-struct ShareSheet: UIViewControllerRepresentable {
-    let activityItems: [Any]
-
-    func makeUIViewController(context: Context) -> UIActivityViewController {
-        UIActivityViewController(activityItems: activityItems, applicationActivities: nil)
-    }
-
-    func updateUIViewController(_ uiViewController: UIActivityViewController, context: Context) {}
-}
-#endif

PVUI/Sources/PVSwiftUI/Settings/Views/BackupRestoreView.swift

@@ -113,13 +113,13 @@ struct BackupRestoreView: View {
             #endif
         }
         #if !os(tvOS)
-        .onChange(of: coordinator.backupState) { state in
+        .onChange(of: coordinator.backupState) { _, state in
             if state == .done, coordinator.backupURL != nil {
                 showShareSheet = true
             }
         }
         #endif
-        .onChange(of: coordinator.restoreState) { state in
+        .onChange(of: coordinator.restoreState) { _, state in
             switch state {
             case .done(let restored):
                 // Release security-scoped access now that restore has finished

PVUI/Sources/PVSwiftUI/Settings/Views/BatchArtworkMatchingView.swift

@@ -58,7 +58,6 @@ public struct BatchArtworkMatchingView: View {
 
     // Animation states for retrowave effects
     @State private var glowOpacity: Double = 0.7
-    @State private var scanlineOffset: CGFloat = 0
 
     // MARK: - Body
 
@@ -314,6 +313,7 @@ public struct BatchArtworkMatchingView: View {
                     Text("REFRESH")
                         .font(.system(size: 14, weight: .bold))
                 }
+                .foregroundColor(.white)
                 .frame(maxWidth: .infinity)
                 .padding(.vertical, 12)
                 .background(