Skip to content

Commit 24afadb

Browse files
authored
Merge pull request #35 from chengyumeng/hotfix/check_email
Fix the problem of creating a user verification in the background is not strict.
2 parents 49c3273 + 350d630 commit 24afadb

File tree

9 files changed

+23
-14
lines changed

9 files changed

+23
-14
lines changed

src/frontend/src/app/admin/configmap/create-edit-configmap/create-edit-configmap.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ <h3 class="modal-title">{{title}}</h3>
44
<form #ngForm="ngForm">
55
<section class="form-block">
66
<div class="form-group" style="padding-left: 135px;">
7-
<label for="app_id" class="col-md-3 form-group-label-override required">应用</label>
7+
<label for="app_id" class="col-md-3 form-group-label-override required">项目</label>
88
<div class="select form-control">
99
<select id="app_id" [(ngModel)]="configMap.appId" [disabled]="actionType==1" name="app_id">
1010
<!--这是一个坑,如果使用value获取到的是string,使用ngValue获取到的是model本身类型-->

src/frontend/src/app/admin/cronjob/create-edit-cronjob/create-edit-cronjob.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ <h3 class="modal-title">{{title}}</h3>
44
<form #ngForm="ngForm">
55
<section class="form-block">
66
<div class="form-group" style="padding-left: 135px;">
7-
<label for="app_id" class="col-md-3 form-group-label-override required">应用</label>
7+
<label for="app_id" class="col-md-3 form-group-label-override required">项目</label>
88
<div class="select form-control">
99
<select id="app_id" [(ngModel)]="cronjob.appId" [disabled]="actionType==1" name="app_id">
1010
<!--这是一个坑,如果使用value获取到的是string,使用ngValue获取到的是model本身类型-->

src/frontend/src/app/admin/daemonset/create-edit-daemonset/create-edit-daemonset.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ <h3 class="modal-title">{{title}}</h3>
55

66
<section class="form-block">
77
<div class="form-group" style="padding-left: 135px;">
8-
<label for="app_id" class="col-md-3 form-group-label-override required">应用</label>
8+
<label for="app_id" class="col-md-3 form-group-label-override required">项目</label>
99
<div class="select form-control">
1010
<select id="app_id" [(ngModel)]="daemonset.appId" [disabled]="actionType==1" name="app_id">
1111
<option *ngFor="let app of apps" [ngValue]="app.id" [selected]="app.id == daemonset.appId">{{app.name}}

src/frontend/src/app/admin/deployment/create-edit-deployment/create-edit-deployment.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ <h3 class="modal-title">{{deploymentTitle}}</h3>
55

66
<section class="form-block">
77
<div class="form-group" style="padding-left: 135px;">
8-
<label for="deployment_app_id" class="col-md-3 form-group-label-override required">应用</label>
8+
<label for="deployment_app_id" class="col-md-3 form-group-label-override required">项目</label>
99
<div class="select form-control">
1010
<select id="deployment_app_id" [(ngModel)]="deployment.appId" [disabled]="actionType==1" name="deployment_app_id">
1111
<!--这是一个坑,如果使用value获取到的是string,使用ngValue获取到的是model本身类型-->

src/frontend/src/app/admin/persistentvolumeclaim/create-edit-persistentvolumeclaim/create-edit-persistentvolumeclaim.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ <h3 class="modal-title">{{title}}</h3>
44
<form #ngForm="ngForm">
55
<section class="form-block">
66
<div class="form-group" style="padding-left: 135px;">
7-
<label for="app_id" class="col-md-3 form-group-label-override required">应用</label>
7+
<label for="app_id" class="col-md-3 form-group-label-override required">项目</label>
88
<div class="select form-control">
99
<select id="app_id" [(ngModel)]="pvc.appId" [disabled]="actionType==1" name="app_id">
1010
<!--这是一个坑,如果使用value获取到的是string,使用ngValue获取到的是model本身类型-->

src/frontend/src/app/admin/secret/create-edit-secret/create-edit-secret.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ <h3 class="modal-title">{{secretTitle}}</h3>
44
<form #secretForm="ngForm">
55
<section class="form-block">
66
<div class="form-group" style="padding-left: 135px;">
7-
<label for="app_id" class="col-md-3 form-group-label-override required">应用</label>
7+
<label for="app_id" class="col-md-3 form-group-label-override required">项目</label>
88
<div class="select form-control">
99
<select id="app_id" [(ngModel)]="secret.appId" [disabled]="actionType==1" name="app_id">
1010
<option *ngFor="let app of apps" [ngValue]="app.id" [selected]="app.id == secret.appId">{{app.name}}

src/frontend/src/app/admin/statefulset/create-edit-statefulset/create-edit-statefulset.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ <h3 class="modal-title">{{title}}</h3>
55

66
<section class="form-block">
77
<div class="form-group" style="padding-left: 135px;">
8-
<label for="app_id" class="col-md-3 form-group-label-override required">应用</label>
8+
<label for="app_id" class="col-md-3 form-group-label-override required">项目</label>
99
<div class="select form-control">
1010
<select id="app_id" [(ngModel)]="statefulset.appId" [disabled]="actionType==1" name="app_id">
1111
<!--这是一个坑,如果使用value获取到的是string,使用ngValue获取到的是model本身类型-->

src/frontend/src/app/admin/user/create-edit-user/create-edit-user.component.html

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ <h3 class="modal-title">{{userTitle}}</h3>
1111
required
1212
pattern="[a-z]([-a-z0-9]*[a-z0-9])?"
1313
maxlength="24"
14-
(keyup)='handleValidation()'>
14+
(keyup)='handleNameValidation()'>
1515
<span class="tooltip-content">
1616
用户名称不符合规范,验证规则[a-z]([-a-z0-9]*[a-z0-9])?
1717
</span>
@@ -20,11 +20,12 @@ <h3 class="modal-title">{{userTitle}}</h3>
2020
</div>
2121
<div class="form-group" style="padding-left: 135px;">
2222
<label for="user_email" class="col-md-3 form-group-label-override required">邮箱</label>
23-
<label for="user_email" aria-haspopup="true" role="tooltip" [class.invalid]="!isNameValid" class="tooltip tooltip-validation tooltip-md tooltip-bottom-left">
23+
<label for="user_email" aria-haspopup="true" role="tooltip" [class.invalid]="!isEmailValid" class="tooltip tooltip-validation tooltip-md tooltip-bottom-left">
2424
<input type="text" id="user_email" [(ngModel)]="user.email"
2525
name="user_email" size="36"
2626
required
27-
maxlength="128"
27+
pattern="^([A-Za-z0-9_\-\.\u4e00-\u9fa5])+\@([A-Za-z0-9_\-\.])+\.([A-Za-z]{2,15})$"
28+
maxlength="128" (keyup)='handleEmailValidation()'
2829
>
2930
<span class="tooltip-content">
3031
用户邮箱不符合规范
@@ -34,11 +35,11 @@ <h3 class="modal-title">{{userTitle}}</h3>
3435
</div>
3536
<div class="form-group" style="padding-left: 135px;">
3637
<label for="user_display" class="col-md-3 form-group-label-override required">展示</label>
37-
<label for="user_display" aria-haspopup="true" role="tooltip" [class.invalid]="!isNameValid" class="tooltip tooltip-validation tooltip-md tooltip-bottom-left">
38+
<label for="user_display" aria-haspopup="true" role="tooltip" [class.invalid]="!isDisplayValid" class="tooltip tooltip-validation tooltip-md tooltip-bottom-left">
3839
<input type="text" id="user_display" [(ngModel)]="user.display"
3940
name="user_display" size="36"
4041
required
41-
maxlength="128"
42+
maxlength="128" (keyup)='isDisplayValid = user.display.trim().length>0'
4243
>
4344
<span class="tooltip-content">
4445
用户展示不符合规范

src/frontend/src/app/admin/user/create-edit-user/create-edit-user.component.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ export class CreateEditUserComponent {
2525
checkOnGoing: boolean = false;
2626
isSubmitOnGoing: boolean = false;
2727
isNameValid: boolean = true;
28+
isDisplayValid: boolean = true;
29+
isEmailValid: boolean = true;
2830

2931
userTitle: string;
3032
actionType: ActionType;
@@ -109,15 +111,21 @@ export class CreateEditUserComponent {
109111
this.currentForm.valid &&
110112
!this.isSubmitOnGoing &&
111113
this.isNameValid &&
112-
!this.checkOnGoing;
114+
!this.checkOnGoing && this.isEmailValid && this.isDisplayValid;
113115
}
114116

115117
// Handle the form validation
116-
handleValidation(): void {
118+
handleNameValidation(): void {
117119
let cont = this.currentForm.controls['user_name'];
118120
if (cont) {
119121
this.isNameValid = cont.valid
120122
}
121123
}
124+
handleEmailValidation(): void {
125+
let cont = this.currentForm.controls['user_email'];
126+
if (cont) {
127+
this.isEmailValid = cont.valid
128+
}
129+
}
122130
}
123131

0 commit comments

Comments
 (0)