Fix checking for deprecation warnings to use assertWarns() (#14145)

Fix the deprecation warning check to use the correct `assertWarns()`
method rather than `assertRaises()` that is used to test for exceptions.
This fixes the test suite when it is run without `-Werror`.

Author: mgorny

test/python/circuit/test_scheduled_circuit.py

@@ -51,7 +51,7 @@ def test_schedule_circuit_when_backend_tells_dt(self):
         backend = GenericBackendV2(2, seed=42)
 
         sc = transpile(qc, backend, scheduling_method="alap", layout_method="trivial")
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             self.assertEqual(sc.duration, 451095)
             self.assertEqual(sc.unit, "dt")
         self.assertEqual(sc.data[0].operation.name, "delay")
@@ -78,7 +78,7 @@ def test_schedule_circuit_when_transpile_option_tells_dt(self):
             seed_transpiler=20,
         )
         target_durations = self.backend_with_dt.target.durations()
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             self.assertAlmostEqual(sc.duration, (450450 + target_durations.get("sx", 0)))
             self.assertEqual(sc.unit, "dt")
         self.assertEqual(sc.data[0].operation.name, "delay")
@@ -104,7 +104,7 @@ def test_schedule_circuit_in_sec_when_no_one_tells_dt(self):
         )
         target_durations = self.backend_with_dt.target.durations()
 
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             self.assertAlmostEqual(sc.duration, (450450 + target_durations.get("sx", 0)) * self.dt)
             self.assertEqual(sc.unit, "s")
         self.assertEqual(sc.data[0].operation.name, "delay")
@@ -129,7 +129,7 @@ def test_transpile_single_delay_circuit(self):
         qc = QuantumCircuit(1)
         qc.delay(1234, 0)
         sc = transpile(qc, backend=self.backend_with_dt, scheduling_method="alap")
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             self.assertEqual(sc.duration, 1234)
         self.assertEqual(sc.data[0].operation.name, "delay")
         self.assertEqual(sc.data[0].operation.duration, 1234)
@@ -146,7 +146,7 @@ def test_transpile_t1_circuit(self):
         expected_scheduled = (
             target_durations.get("x", 1) + 4500 + target_durations.get("measure", 1)
         )
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             self.assertEqual(scheduled.duration, expected_scheduled)
 
     def test_transpile_delay_circuit_with_backend(self):
@@ -158,7 +158,7 @@ def test_transpile_delay_circuit_with_backend(self):
             qc, backend=self.backend_with_dt, scheduling_method="alap", layout_method="trivial"
         )
         target_durations = self.backend_with_dt.target.durations()
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             self.assertEqual(scheduled.duration, target_durations.get("cx", (0, 1)) + 450)
 
     def test_transpile_circuit_with_custom_instruction(self):
@@ -191,14 +191,14 @@ def test_transpile_circuit_with_custom_instruction(self):
             target=target,
             dt=1e-2,
         )
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             self.assertEqual(scheduled.duration, 1500)
 
     def test_transpile_delay_circuit_with_dt_but_without_scheduling_method(self):
         qc = QuantumCircuit(1)
         qc.delay(100, 0, unit="ns")
         transpiled = transpile(qc, backend=self.backend_with_dt)
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             self.assertEqual(transpiled.duration, None)  # not scheduled
         self.assertEqual(transpiled.data[0].operation.duration, 450)  # unit is converted ns -> dt
 
@@ -208,7 +208,7 @@ def test_transpile_delay_circuit_without_scheduling_method_or_durs(self):
         qc.delay(500, 1)
         qc.cx(0, 1)
         not_scheduled = transpile(qc)
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             self.assertEqual(not_scheduled.duration, None)
 
     def test_raise_error_if_transpile_with_scheduling_method_but_without_durations(self):
@@ -227,7 +227,7 @@ def test_invalidate_schedule_circuit_if_new_instruction_is_appended(self):
         scheduled = transpile(qc, backend=self.backend_with_dt, scheduling_method="alap")
         # append a gate to a scheduled circuit
         scheduled.h(0)
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             self.assertEqual(scheduled.duration, None)
 
     def test_unit_seconds_when_using_backend_durations(self):
@@ -240,7 +240,7 @@ def test_unit_seconds_when_using_backend_durations(self):
             qc, backend=self.backend_with_dt, scheduling_method="alap", layout_method="trivial"
         )
         target_durations = self.backend_with_dt.target.durations()
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             self.assertEqual(scheduled.duration, target_durations.get("cx", (0, 1)) + 500)
 
     def test_per_qubit_durations(self):
@@ -300,7 +300,7 @@ def test_convert_duration_to_dt(self):
         circ.measure_all()
 
         circuit_dt = transpile(circ, backend, scheduling_method="asap")
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             # reference duration and unit in dt
             ref_duration = circuit_dt.duration
             ref_unit = circuit_dt.unit
@@ -490,7 +490,7 @@ def test_change_dt_in_transpile(self):
             backend=GenericBackendV2(1, basis_gates=["x"], seed=2, dt=self.dt),
             scheduling_method="asap",
         )
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             org_duration = scheduled.duration
         # halve dt in sec = double duration in dt
         scheduled = transpile(
@@ -499,7 +499,7 @@ def test_change_dt_in_transpile(self):
             scheduling_method="asap",
             dt=self.dt / 2,
         )
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             self.assertEqual(scheduled.duration, org_duration * 2)
 
     @data("asap", "alap")
@@ -526,7 +526,7 @@ def test_can_transpile_circuits_after_assigning_parameters(self):
         qc.measure(0, 0)
         qc = qc.assign_parameters({idle_dur: 0.1})
         circ = transpile(qc, self.backend_with_dt)
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             self.assertEqual(circ.duration, None)  # not scheduled
         self.assertEqual(circ.data[1].operation.duration, 450)  # converted in dt
 
@@ -549,7 +549,7 @@ def test_can_transpile_circuits_with_unbounded_parameters(self):
         qc.measure(0, 0)
         # not assign parameter
         circ = transpile(qc, self.backend_with_dt)
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             self.assertEqual(circ.duration, None)  # not scheduled
         self.assertEqual(circ.data[1].operation.unit, "dt")  # converted in dt
         self.assertEqual(
@@ -565,7 +565,7 @@ def test_can_schedule_circuits_with_bounded_parameters(self, scheduling_method):
         qc.measure(0, 0)
         qc = qc.assign_parameters({idle_dur: 0.1})
         circ = transpile(qc, self.backend_with_dt, scheduling_method=scheduling_method)
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             self.assertIsNotNone(circ.duration)  # scheduled
 
     @data("asap", "alap")

test/python/compiler/test_transpiler.py

@@ -1318,7 +1318,7 @@ def test_circuit_with_delay(self, optimization_level):
             seed_transpiler=42,
         )
 
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             self.assertEqual(out.unit, "dt")
             self.assertEqual(out.duration, 1200)
 
@@ -1356,7 +1356,7 @@ def test_circuit_with_delay_expr_duration(self, optimization_level):
             seed_transpiler=42,
         )
 
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             self.assertEqual(out.unit, "dt")
             self.assertEqual(out.duration, 1200)
 
@@ -1649,7 +1649,7 @@ def test_scheduling_instruction_constraints_backend(self):
             scheduling_method="alap",
             layout_method="trivial",
         )
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             self.assertEqual(scheduled.duration, 9010)
 
     def test_scheduling_instruction_constraints(self):
@@ -1674,7 +1674,7 @@ def test_scheduling_instruction_constraints(self):
             scheduling_method="alap",
             layout_method="trivial",
         )
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             self.assertEqual(scheduled.duration, 9010)
 
     def test_scheduling_dt_constraints(self):
@@ -1687,12 +1687,12 @@ def test_scheduling_dt_constraints(self):
         qc.x(0)
         qc.measure(0, 0)
         scheduled = transpile(qc, backend=backend_v2, scheduling_method="asap")
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             original_duration = scheduled.duration
 
         # halve dt in sec = double duration in dt
         scheduled = transpile(qc, backend=backend_v2, scheduling_method="asap", dt=original_dt / 2)
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             self.assertEqual(scheduled.duration, original_duration * 2)
 
     @data(1, 2, 3)

test/python/dagcircuit/test_dagcircuit.py

@@ -498,7 +498,7 @@ def test_copy_empty_like(self):
         self.assertEqual(self.dag.qubits, result_dag.qubits)
         self.assertEqual(self.dag.cregs, result_dag.cregs)
         self.assertEqual(self.dag.qregs, result_dag.qregs)
-        with self.assertRaises(DeprecationWarning):
+        with self.assertWarns(DeprecationWarning):
             self.assertEqual(self.dag.duration, result_dag.duration)
             self.assertEqual(self.dag.unit, result_dag.unit)