Bump rand crates to 0.10.x releases (#16051)

* Bump rand crates to 0.10.x releases

This commit bumps the rand crates used in Qiskit to the current latest
releases. There is constellation of crates for rand, including the core
library, specific generators, and distributions. These all have to be
upgraded in lockstep for compatibility. We had put off doing this likely
because dependabot isn't able to reason about this and these upgrades
often have breaking api changes. This release is no different as the way
to instantiate a random number generator from system entropy has change
yet again (this is the second or third such change I can remember). This
updates all the usage of rand crates in qiskit to be compatible with the
new releases.

Closes #16009

* Use prelude instead of explicit traits

* Run cargo fmt

Author: mtreinish

Cargo.lock

@@ -35,9 +35,9 @@ rayon = "1.12"
 nom = "8.0"
 nom-unicode = "0.4"
 nom-language = "0.1"
-rand = "0.9"
-rand_pcg = "0.9"
-rand_distr = "0.5"
+rand = "0.10"
+rand_pcg = "0.10"
+rand_distr = "0.6"
 num-traits = "0.2"
 uuid = { version = "1.23", features = ["v4", "fast-rng"], default-features = false }
 anyhow = "1.0"

Cargo.toml

@@ -34,6 +34,7 @@ use qiskit_circuit::{BlocksMode, NoBlocks, VarsMode};
 use qiskit_transpiler::passes::run_optimize_1q_gates_decomposition;
 use qiskit_transpiler::target::Target;
 use rand::prelude::*;
+use rand::rngs::SysRng;
 use rand_pcg::Pcg64Mcg;
 
 static ECR_TWIRL_SET: [([StandardGate; 4], f64); 16] = [
@@ -316,7 +317,7 @@ pub(crate) fn twirl_circuit(
 ) -> PyResult<Vec<PyCircuitData>> {
     let mut rng = match seed {
         Some(seed) => Pcg64Mcg::seed_from_u64(seed),
-        None => Pcg64Mcg::from_os_rng(),
+        None => Pcg64Mcg::try_from_rng(&mut SysRng).unwrap(),
     };
     let twirling_mask: u8 = match twirled_gate {
         Some(gates) => {

crates/accelerate/src/twirling.rs

@@ -11,7 +11,8 @@
 // that they have been altered from the originals.
 
 use crate::pointers::{const_ptr_as_ref, mut_ptr_as_ref};
-use rand::{Rng, SeedableRng};
+use rand::prelude::*;
+use rand::rngs::SysRng;
 use rand_pcg::Pcg64Mcg;
 
 use qiskit_circuit::circuit_data::CircuitData;
@@ -52,7 +53,7 @@ pub extern "C" fn qk_sabre_layout_options_default() -> SabreLayoutOptions {
         max_iterations: 4,
         num_swap_trials: 20,
         num_random_trials: 20,
-        seed: Pcg64Mcg::from_os_rng().random(),
+        seed: Pcg64Mcg::try_from_rng(&mut SysRng).unwrap().random(),
     }
 }
 

crates/cext/src/transpiler/passes/sabre_layout.rs

@@ -20,7 +20,8 @@ use qiskit_circuit::{
     circuit_data::{CircuitData, PyCircuitData},
     operations::{Param, StandardGate},
 };
-use rand::{Rng, SeedableRng};
+use rand::prelude::*;
+use rand::rngs::SysRng;
 use rand_pcg::Pcg64Mcg;
 use smallvec::{SmallVec, smallvec};
 
@@ -80,7 +81,7 @@ fn generate_random_interactions(num_qubits: u32, seed: Option<u64>) -> Array2<i6
     let num_qubits = num_qubits as usize;
     let mut rng = match seed {
         Some(seed) => Pcg64Mcg::seed_from_u64(seed),
-        None => Pcg64Mcg::from_os_rng(),
+        None => Pcg64Mcg::try_from_rng(&mut SysRng).unwrap(),
     };
 
     let mut mat = Array2::zeros((num_qubits, num_qubits));

crates/circuit_library/src/iqp.rs

@@ -15,6 +15,7 @@ use pyo3::prelude::*;
 use nalgebra::Matrix4;
 use num_complex::{Complex64, ComplexFloat};
 use rand::prelude::*;
+use rand::rngs::SysRng;
 use rand_distr::StandardNormal;
 use rand_pcg::Pcg64Mcg;
 use rayon::prelude::*;
@@ -116,7 +117,7 @@ pub fn quantum_volume(num_qubits: u32, depth: usize, seed: Option<u64>) -> PyRes
     }
     let mut outer_rng = match seed {
         Some(seed) => Pcg64Mcg::seed_from_u64(seed),
-        None => Pcg64Mcg::from_os_rng(),
+        None => Pcg64Mcg::try_from_rng(&mut SysRng).unwrap(),
     };
     let seed_vec: Vec<u64> = rand::distr::StandardUniform
         .sample_iter(&mut outer_rng)

crates/circuit_library/src/quantum_volume.rs

@@ -25,6 +25,7 @@ use std::{
 };
 
 use rand::prelude::*;
+use rand::rngs::SysRng;
 use rand_distr::Bernoulli;
 use rand_pcg::Pcg64Mcg;
 
@@ -394,7 +395,7 @@ impl PauliLindbladMap {
     ) -> (Vec<bool>, QubitSparsePauliList) {
         let mut rng = match seed {
             Some(seed) => Pcg64Mcg::seed_from_u64(seed),
-            None => Pcg64Mcg::from_os_rng(),
+            None => Pcg64Mcg::try_from_rng(&mut SysRng).unwrap(),
         };
         let modified_probabilities;
         let modified_non_negative_rates;

crates/quantum_info/src/pauli_lindblad_map/pauli_lindblad_map_class.rs

@@ -14,7 +14,8 @@ use crate::linear::utils::{
     binary_matmul_inner, calc_inverse_matrix_inner, replace_row_inner, swap_rows_inner,
 };
 use ndarray::{Array1, Array2, ArrayView2, ArrayViewMut2, Axis, concatenate, s};
-use rand::{Rng, SeedableRng};
+use rand::prelude::*;
+use rand::rngs::SysRng;
 use rand_pcg::Pcg64Mcg;
 
 /// Sample from the quantum Mallows distribution.
@@ -67,7 +68,7 @@ fn inverse_tril(mat: ArrayView2<bool>) -> Array2<bool> {
 pub fn random_clifford_tableau_inner(num_qubits: usize, seed: Option<u64>) -> Array2<bool> {
     let mut rng = match seed {
         Some(seed) => Pcg64Mcg::seed_from_u64(seed),
-        None => Pcg64Mcg::from_os_rng(),
+        None => Pcg64Mcg::try_from_rng(&mut SysRng).unwrap(),
     };
 
     let (had, perm) = sample_qmallows(num_qubits, &mut rng);

crates/synthesis/src/clifford/random_clifford.rs

@@ -13,7 +13,8 @@
 use ndarray::{
     Array1, Array2, ArrayView1, ArrayView2, ArrayViewMut2, Axis, Zip, azip, concatenate, s,
 };
-use rand::{Rng, SeedableRng};
+use rand::prelude::*;
+use rand::rngs::SysRng;
 use rand_pcg::Pcg64Mcg;
 use rayon::iter::{IndexedParallelIterator, ParallelIterator};
 use rayon::prelude::IntoParallelIterator;
@@ -221,7 +222,7 @@ pub fn _row_sum(row_1: ArrayView1<bool>, row_2: ArrayView1<bool>) -> Result<Arra
 pub fn random_invertible_binary_matrix_inner(num_qubits: usize, seed: Option<u64>) -> Array2<bool> {
     let mut rng = match seed {
         Some(seed) => Pcg64Mcg::seed_from_u64(seed),
-        None => Pcg64Mcg::from_os_rng(),
+        None => Pcg64Mcg::try_from_rng(&mut SysRng).unwrap(),
     };
 
     let mut matrix = Array2::from_elem((num_qubits, num_qubits), false);

crates/synthesis/src/linear/utils.rs

@@ -16,6 +16,7 @@ use pyo3::prelude::*;
 use hashbrown::HashSet;
 use ndarray::aview2;
 use rand::prelude::*;
+use rand::rngs::SysRng;
 use rand_pcg::Pcg64Mcg;
 use rayon_cond::CondIterator;
 use rustworkx_core::petgraph::graph::NodeIndex;
@@ -85,7 +86,7 @@ pub fn sabre_layout_and_routing(
     let seeds = |count| {
         match seed {
             Some(seed) => Pcg64Mcg::seed_from_u64(seed),
-            None => Pcg64Mcg::from_os_rng(),
+            None => Pcg64Mcg::try_from_rng(&mut SysRng).unwrap(),
         }
         .sample_iter(&rand::distr::StandardUniform)
         .take(count)