Skip to content

Commit 14b7b0e

Browse files
committed
fixed linter
1 parent 53cb7e2 commit 14b7b0e

1 file changed

Lines changed: 24 additions & 19 deletions

File tree

share/rocmcmakebuildtools/cmake/ROCMSetupVersion.cmake

Lines changed: 24 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
# ######################################################################################################################
22
# Copyright (C) 2026 Advanced Micro Devices, Inc.
33
# ######################################################################################################################
4-
cmake_minimum_required(VERSION 3.17 FATAL_ERROR)
4+
if(WIN32)
5+
cmake_minimum_required(VERSION 3.17 FATAL_ERROR)
6+
endif()
57

68
include_guard(GLOBAL)
79

@@ -177,8 +179,11 @@ endfunction()
177179
function(rocm_add_version_resource TARGET NAME DESCRIPTION)
178180
if(WIN32)
179181
get_target_property(TARGET_TYPE ${TARGET} TYPE)
180-
if (NOT TARGET_TYPE STREQUAL "EXECUTABLE" AND NOT TARGET_TYPE STREQUAL "SHARED_LIBRARY" AND NOT TARGET_TYPE STREQUAL "MODULE_LIBRARY")
181-
message(FATAL_ERROR "${CMAKE_CURRENT_FUNCTION}: only EXECUTABLE, SHARED_LIBRARY, and MODULE_LIBRARY target types are supported")
182+
if (NOT TARGET_TYPE STREQUAL "EXECUTABLE" AND
183+
NOT TARGET_TYPE STREQUAL "SHARED_LIBRARY" AND
184+
NOT TARGET_TYPE STREQUAL "MODULE_LIBRARY")
185+
message(FATAL_ERROR "${CMAKE_CURRENT_FUNCTION}: only EXECUTABLE, SHARED_LIBRARY, "
186+
"and MODULE_LIBRARY target types are supported")
182187
endif()
183188
get_target_property(FILENAME ${TARGET} OUTPUT_NAME)
184189
if(NOT FILENAME)
@@ -210,24 +215,24 @@ FILETYPE VFT_APP
210215
#endif
211216
FILESUBTYPE VFT2_UNKNOWN
212217
BEGIN
213-
BLOCK \"StringFileInfo\"
218+
BLOCK \"StringFileInfo\"
219+
BEGIN
220+
BLOCK \"040904B0\"
214221
BEGIN
215-
BLOCK \"040904B0\"
216-
BEGIN
217-
VALUE \"CompanyName\", \"Advanced Micro Devices, Inc.\\0\"
218-
VALUE \"FileDescription\", \"${DESCRIPTION}\\0\"
219-
VALUE \"FileVersion\", \"${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH}.0\\0\"
220-
VALUE \"InternalName\", \"${NAME}\\0\"
221-
VALUE \"LegalCopyright\", \"Copyright (c) ${YEAR} Advanced Micro Devices, Inc. All rights reserved.\\0\"
222-
VALUE \"OriginalFilename\", \"${FILENAME}\\0\"
223-
VALUE \"ProductName\", \"${NAME} ${FILENAME}\\0\"
224-
VALUE \"ProductVersion\", \"${PROJECT_VERSION}\\0\"
225-
END
226-
END
227-
BLOCK \"VarFileInfo\"
228-
BEGIN
229-
VALUE \"Translation\", 0x409, 1200
222+
VALUE \"CompanyName\", \"Advanced Micro Devices, Inc.\\0\"
223+
VALUE \"FileDescription\", \"${DESCRIPTION}\\0\"
224+
VALUE \"FileVersion\", \"${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH}.0\\0\"
225+
VALUE \"InternalName\", \"${NAME}\\0\"
226+
VALUE \"LegalCopyright\", \"Copyright (c) ${YEAR} Advanced Micro Devices, Inc. All rights reserved.\\0\"
227+
VALUE \"OriginalFilename\", \"${FILENAME}\\0\"
228+
VALUE \"ProductName\", \"${NAME} ${FILENAME}\\0\"
229+
VALUE \"ProductVersion\", \"${PROJECT_VERSION}\\0\"
230230
END
231+
END
232+
BLOCK \"VarFileInfo\"
233+
BEGIN
234+
VALUE \"Translation\", 0x409, 1200
235+
END
231236
END
232237
")
233238
target_sources(${TARGET} PRIVATE ${RC_OUTPUT})

0 commit comments

Comments
 (0)