Support repeatedly inserting at the same position.#5
Merged
Rich-Harris merged 2 commits intoRich-Harris:masterfrom Jan 15, 2015
eventualbuddha:insert-at-same-position-fails
Merged
Support repeatedly inserting at the same position.#5Rich-Harris merged 2 commits intoRich-Harris:masterfrom eventualbuddha:insert-at-same-position-fails
Rich-Harris merged 2 commits intoRich-Harris:masterfrom
eventualbuddha:insert-at-same-position-fails
Conversation
Contributor
Author
|
Just added a commit that fixes the issue by handling inserts as distinct from replacements. I've confirmed this fixes the issue in the original project where I found the bug. It also adds an assertion in |
eventualbuddha
changed the title
Rich-Harris
added a commit
that referenced
this pull request
Jan 15, 2015
Support repeatedly inserting at the same position.
Owner
|
Excellent, many thanks - released 0.3.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that inserting at the same position multiple times can cause parts of the string to duplicate. The example in this commit is given
aband inserting1betweenaandb, followed by inserting2at the same position, yieldsa121binstead of the expecteda21b.