fix: add null guards for user in AgentInfo and AddAgent

- AgentInfo.tsx: handle user: null by showing 'User_not_found'
- DepartmentAgentsTable/AddAgent.tsx: guard against null user
- useAgentsList.ts: relax formatAgentItem type for object response

Author: amitb0ra

apps/meteor/client/views/omnichannel/agents/AgentInfo.tsx

@@ -1,3 +1,4 @@
+import type { ILivechatAgent, Serialized } from '@rocket.chat/core-typings';
 import { Box, Margins, ButtonGroup } from '@rocket.chat/fuselage';
 import {
 	ContextualbarTitle,
@@ -39,11 +40,12 @@ const AgentInfo = ({ uid }: AgentInfoProps) => {
 		return <ContextualbarSkeletonBody />;
 	}
 
-	if (isError) {
+	if (isError || !data?.user) {
 		return <Box mbs={16}>{t('User_not_found')}</Box>;
 	}
 
-	const { username, statusLivechat, status: userStatus } = data?.user;
+	const user = data.user as Serialized<ILivechatAgent>;
+	const { username, statusLivechat, status: userStatus } = user;
 
 	return (
 		<>
@@ -77,7 +79,7 @@ const AgentInfo = ({ uid }: AgentInfoProps) => {
 							<InfoPanelText>{statusLivechat === 'available' ? t('Available') : t('Not_Available')}</InfoPanelText>
 						</>
 					)}
-					{MaxChatsPerAgentDisplay && <MaxChatsPerAgentDisplay maxNumberSimultaneousChat={data.user.livechat?.maxNumberSimultaneousChat} />}
+					{MaxChatsPerAgentDisplay && <MaxChatsPerAgentDisplay maxNumberSimultaneousChat={user.livechat?.maxNumberSimultaneousChat} />}
 				</Margins>
 			</ContextualbarScrollableContent>
 		</>

apps/meteor/client/views/omnichannel/departments/DepartmentAgentsTable/AddAgent.tsx

@@ -30,9 +30,12 @@ function AddAgent({ agentList, onAdd, 'aria-labelledby': ariaLabelledBy }: AddAg
 			return;
 		}
 
-		const {
-			user: { _id, username, name },
-		} = await getAgent();
+		const { user } = await getAgent();
+		if (!user) {
+			dispatchToastMessage({ type: 'error', message: t('User_not_found') });
+			return;
+		}
+		const { _id, username, name } = user;
 
 		if (!agentList.some(({ agentId }) => agentId === _id)) {
 			setUserId('');

apps/meteor/client/views/omnichannel/hooks/useAgentsList.ts

@@ -1,4 +1,3 @@
-import type { ILivechatAgent, Serialized } from '@rocket.chat/core-typings';
 import { useEndpoint } from '@rocket.chat/ui-contexts';
 import { useInfiniteQuery } from '@tanstack/react-query';
 import { useTranslation } from 'react-i18next';
@@ -34,7 +33,7 @@ export const useAgentsList = (options: AgentsListOptions) => {
 		limit = DEFAULT_QUERY_LIMIT,
 	} = options;
 
-	const formatAgentItem = (agent: Serialized<ILivechatAgent>) => ({
+	const formatAgentItem = (agent: { _id: string; name?: string; username?: string }) => ({
 		_id: agent._id,
 		label: `${agent.name || agent._id} (@${agent.username})`,
 		value: agent._id,
@@ -55,7 +54,7 @@ export const useAgentsList = (options: AgentsListOptions) => {
 
 			return {
 				...data,
-				users: users.map(formatAgentItem),
+				users: users.map((u: any) => formatAgentItem(u)),
 			};
 		},
 		select: (data) => {