Merge pull request #822 from RocketChat/models

Replace Collections by Models

Author: rodrigok

client/views/app/messagePopupConfig.coffee

@@ -1,19 +1,19 @@
-@onlineUsers = new Mongo.Collection 'online-users'
+@filteredUsers = new Mongo.Collection 'filtered-users'
 
 Template.messagePopupConfig.helpers
 	popupUserConfig: ->
 		self = this
 		template = Template.instance()
 		config =
 			title: 'People'
-			collection: onlineUsers
+			collection: filteredUsers
 			template: 'messagePopupUser'
 			getInput: self.getInput
 			textFilterDelay: 200
 			getFilter: (collection, filter) ->
 				exp = new RegExp("^#{filter}", 'i')
-				Meteor.subscribe 'onlineUsers', filter
-				items = onlineUsers.find({$or: [{username: exp}, {name: exp}]}, {limit: 5}).fetch()
+				Meteor.subscribe 'filteredUsers', filter
+				items = filteredUsers.find({$or: [{username: exp}, {name: exp}]}, {limit: 5}).fetch()
 
 				all =
 					_id: '@all'

packages/meteor-accounts-saml/saml_rocketchat.coffee

@@ -16,7 +16,7 @@ updateServices = ->
 	Meteor.clearTimeout timer if timer?
 
 	timer = Meteor.setTimeout ->
-		services = Settings.find({_id: /^(SAML_Custom_)[a-z]+$/i}).fetch()
+		services = RocketChat.models.Settings.find({_id: /^(SAML_Custom_)[a-z]+$/i}).fetch()
 
 		Accounts.saml.settings.providers = []
 
@@ -27,26 +27,26 @@ updateServices = ->
 
 			if service.value is true
 				data =
-					buttonLabelText: Settings.findOne({_id: "#{service._id}_button_label_text"})?.value
-					buttonLabelColor: Settings.findOne({_id: "#{service._id}_button_label_color"})?.value
-					buttonColor: Settings.findOne({_id: "#{service._id}_button_color"})?.value
+					buttonLabelText: RocketChat.models.Settings.findOneById("#{service._id}_button_label_text")?.value
+					buttonLabelColor: RocketChat.models.Settings.findOneById("#{service._id}_button_label_color")?.value
+					buttonColor: RocketChat.models.Settings.findOneById("#{service._id}_button_color")?.value
 					clientConfig:
-						provider: Settings.findOne({_id: "#{service._id}_provider"})?.value
+						provider: RocketChat.models.Settings.findOneById("#{service._id}_provider")?.value
 
-				Accounts.saml.settings.generateUsername = Settings.findOne({_id: "#{service._id}_generate_username"})?.value
+				Accounts.saml.settings.generateUsername = RocketChat.models.Settings.findOneById("#{service._id}_generate_username")?.value
 
 				Accounts.saml.settings.providers.push
 					provider: data.clientConfig.provider
-					entryPoint: Settings.findOne({_id: "#{service._id}_entry_point"})?.value
-					issuer: Settings.findOne({_id: "#{service._id}_issuer"})?.value
-					cert: Settings.findOne({_id: "#{service._id}_cert"})?.value
+					entryPoint: RocketChat.models.Settings.findOneById("#{service._id}_entry_point")?.value
+					issuer: RocketChat.models.Settings.findOneById("#{service._id}_issuer")?.value
+					cert: RocketChat.models.Settings.findOneById("#{service._id}_cert")?.value
 
 				ServiceConfiguration.configurations.upsert {service: serviceName.toLowerCase()}, $set: data
 			else
 				ServiceConfiguration.configurations.remove {service: serviceName.toLowerCase()}
 	, 2000
 
-Settings.find().observe
+RocketChat.models.Settings.find().observe
 	added: (record) ->
 		if /^SAML_.+/.test record._id
 			updateServices()
@@ -60,5 +60,5 @@ Settings.find().observe
 			updateServices()
 
 Meteor.startup ->
-	if not Settings.findOne({_id: /^(SAML_Custom)[a-z]+$/i})?
+	if not RocketChat.models.Settings.findOne({_id: /^(SAML_Custom)[a-z]+$/i})?
 		Meteor.call 'addSamlService', 'default'

…hat-authorization/lib/permissions.coffee …t-authorization/client/collection.coffeepackages/rocketchat-authorization/lib/permissions.coffee renamed to packages/rocketchat-authorization/client/collection.coffee packages/rocketchat-authorization/lib/permissions.coffee renamed to packages/rocketchat-authorization/client/collection.coffee

@@ -16,13 +16,15 @@ Package.onUse(function(api) {
 
   api.use('templating', 'client');
 
-  api.addFiles('lib/permissions.coffee', ['server', 'client']);
   api.addFiles('lib/rocketchat.coffee', ['server','client']);
+  api.addFiles('client/collection.coffee', ['client']);
   api.addFiles('client/startup.coffee', ['client']);
   api.addFiles('client/hasPermission.coffee', ['client']);
   api.addFiles('client/hasRole.coffee', ['client']);
 
 
+  api.addFiles('server/models/Permissions.coffee', ['server']);
+
   api.addFiles('server/functions/addUsersToRoles.coffee', ['server']);
   api.addFiles('server/functions/getPermissionsForRole.coffee', ['server']);
   api.addFiles('server/functions/getRoles.coffee', ['server']);

packages/rocketchat-authorization/package.js

@@ -6,4 +6,4 @@ RocketChat.authz.getPermissionsForRole = (roleName) ->
 	unless roleName in roleNames
 		throw new Meteor.Error 'invalid-role'
 
-	return _.pluck(ChatPermissions.find({roles : roleName }).fetch(), '_id')
+	return _.pluck(RocketChat.models.Permissions.findByRole( roleName ).fetch(), '_id')

packages/rocketchat-authorization/server/functions/getPermissionsForRole.coffee

@@ -0,0 +1,11 @@
+RocketChat.models.Permissions = new class extends RocketChat.models._Base
+	constructor: ->
+		@_initModel 'permissions'
+
+
+	# FIND
+	findByRole: (role, options) ->
+		query =
+			roles: role
+
+		return @find query, options

packages/rocketchat-authorization/server/models/Permissions.coffee

@@ -1,3 +1,3 @@
 Meteor.publish 'permissions', ->
 	console.log '[publish] permissions'.green
-	return ChatPermissions.find {} 
+	return RocketChat.models.Permissions.find {}

packages/rocketchat-authorization/server/publication.coffee

@@ -78,7 +78,7 @@ Meteor.startup ->
 	roles = _.pluck(Roles.getAllRoles().fetch(), 'name');
 
 	for permission in permissions
-		ChatPermissions.upsert( permission._id, {$setOnInsert : permission })
+		RocketChat.models.Permissions.upsert( permission._id, {$setOnInsert : permission })
 		for role in permission.roles
 			unless role in roles
 				Roles.createRole role

packages/rocketchat-authorization/server/startup.coffee

@@ -160,7 +160,7 @@ class IrcClient
 		console.log '[irc] onReceiveMessage -> '.yellow, 'source:', source, 'target:', target, 'content:', content
 		source = @createUserWhenNotExist source
 		if target[0] == '#'
-			room = ChatRoom.findOne {name: target.substring 1}
+			room = RocketChat.models.Rooms.findOneByName target.substring(1)
 		else
 			room = @createDirectRoomWhenNotExist(source, @user)
 
@@ -178,7 +178,7 @@ class IrcClient
 	onEndMemberList: (roomName) ->
 		newMembers = @receiveMemberListBuf[roomName]
 		console.log '[irc] onEndMemberList -> '.yellow, 'room:', roomName, 'members:', newMembers.join ','
-		room = ChatRoom.findOne {name: roomName, t: 'c'}
+		room = RocketChat.models.Rooms.findOneByNameAndType roomName, 'c'
 		unless room
 			return
 
@@ -189,17 +189,9 @@ class IrcClient
 		for member in appendMembers
 			@createUserWhenNotExist member
 
-		update =
-			$pull:
-				usernames:
-					$in: removeMembers
-		ChatRoom.update room._id, update
-		update =
-			$addToSet:
-				usernames:
-					$each: appendMembers
-
-		ChatRoom.update room._id, update
+		RocketChat.models.Rooms.removeUsernamesById room._id, removeMembers
+		RocketChat.models.Rooms.addUsernamesById room._id, appendMembers
+
 		@isJoiningRoom = false
 		roomName = @pendingJoinRoomBuf.shift()
 		if roomName
@@ -231,15 +223,12 @@ class IrcClient
 		msg = "PRIVMSG #{target} :#{message.msg}\r\n"
 		@sendRawMessage msg
 
-	initRoomList: () ->
-		roomsCursor = ChatRoom.find
-			usernames:
-				$in: [@user.username]
-			t: 'c'
-		,
+	initRoomList: ->
+		roomsCursor = RocketChat.models.Rooms.findByTypeContainigUsername 'c', @user.username,
 			fields:
 				name: 1
 				t: 1
+
 		rooms = roomsCursor.fetch()
 		for room in rooms
 			@joinRoom(room)
@@ -276,25 +265,17 @@ class IrcClient
 
 		console.log '[irc] onAddMemberToRoom -> '.yellow, 'roomName:', roomName, 'member:', member
 		@createUserWhenNotExist member
-		update =
-			$addToSet:
-				usernames: member
 
-		ChatRoom.update {name: roomName}, update
+		RocketChat.models.Rooms.addUsernameByName roomName, member
 
 	onRemoveMemberFromRoom: (member, roomName)->
 		console.log '[irc] onRemoveMemberFromRoom -> '.yellow, 'roomName:', roomName, 'member:', member
-		update =
-			$pull:
-				usernames: member
-		ChatRoom.update {name: roomName}, update
+		RocketChat.models.Rooms.removeUsernameByName roomName, member
 
 	onQuiteMember: (member) ->
 		console.log '[irc] onQuiteMember ->'.yellow, 'username:', member
-		update =
-			$pull:
-				usernames: member
-		ChatRoom.update {}, update, {multi: true}
+		RocketChat.models.Rooms.removeUsernameFromAll member
+
 		Meteor.users.update {name: member},
 			$set:
 				status: 'offline'
@@ -319,7 +300,7 @@ class IrcClient
 		console.log '[irc] createDirectRoomWhenNotExist -> '.yellow, 'source:', source, 'target:', target
 		rid = [source._id, target._id].sort().join('')
 		now = new Date()
-		ChatRoom.upsert
+		RocketChat.models.Rooms.upsert
 			_id: rid
 		,
 			$set:
@@ -328,7 +309,8 @@ class IrcClient
 				t: 'd'
 				msgs: 0
 				ts: now
-		ChatSubscription.upsert
+
+		RocketChat.models.Subscriptions.upsert
 			rid: rid
 			$and: [{'u._id': target._id}]
 		,
@@ -373,7 +355,7 @@ class IrcSender
 		if ircReceiveMessageCache.get cacheKey
 			return message
 
-		room = ChatRoom.findOne message.rid, { fields: { name: 1, usernames: 1, t: 1 } }
+		room = RocketChat.models.Rooms.findOneById message.rid, { fields: { name: 1, usernames: 1, t: 1 } }
 		ircClient = IrcClient.getByUid message.u._id
 		ircClient.sendMessage room, message
 		return message

packages/rocketchat-irc/irc.server.coffee

@@ -14,7 +14,7 @@ updateServices = ->
 	Meteor.clearTimeout timer if timer?
 
 	timer = Meteor.setTimeout ->
-		enable = Settings.findOne({_id: 'LDAP_Enable', value: true})
+		enable = RocketChat.models.Settings.findOne({_id: 'LDAP_Enable', value: true})
 
 		if enable?
 			console.log "Enabling LDAP".blue
@@ -29,7 +29,7 @@ updateServices = ->
 			LDAP_DEFAULTS.bindSearch = undefined
 	, 2000
 
-Settings.find().observe
+RocketChat.models.Settings.find().observe
 	added: (record) ->
 		if /^LDAP_.+/.test record._id
 			updateServices()