Skip to content

Commit 996bccc

Browse files
committed
fix(sidebar): Show full channel name on hover (#38316)
1 parent 08b586d commit 996bccc

File tree

5 files changed

+19
-3
lines changed

5 files changed

+19
-3
lines changed

.changeset/short-names-visible.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@rocket.chat/meteor": patch
3+
---
4+
5+
Fix: Long channel names are truncated and not visible on hover

apps/meteor/client/sidebar/Item/Condensed.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,9 @@ const Condensed = ({ icon, title, avatar, actions, unread, menu, badges, ...prop
2727
<SidebarV2Item {...props} onFocus={handleFocus} onPointerEnter={handlePointerEnter}>
2828
{avatar && <SidebarV2ItemAvatarWrapper>{avatar}</SidebarV2ItemAvatarWrapper>}
2929
{icon}
30-
<SidebarV2ItemTitle unread={unread}>{title}</SidebarV2ItemTitle>
30+
<SidebarV2ItemTitle unread={unread} title={typeof title === 'string' ? title : undefined}>
31+
{title}
32+
</SidebarV2ItemTitle>
3133
{badges}
3234
{actions}
3335
{menu && (

apps/meteor/client/sidebar/Item/Extended.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,9 @@ const Extended = ({
6060
<SidebarV2ItemCol>
6161
<SidebarV2ItemRow>
6262
{icon}
63-
<SidebarV2ItemTitle unread={unread}>{title}</SidebarV2ItemTitle>
63+
<SidebarV2ItemTitle unread={unread} title={typeof title === 'string' ? title : undefined}>
64+
{title}
65+
</SidebarV2ItemTitle>
6466
{time && <SidebarV2ItemTimestamp>{formatDate(time)}</SidebarV2ItemTimestamp>}
6567
</SidebarV2ItemRow>
6668
<SidebarV2ItemRow>

apps/meteor/client/sidebar/Item/Medium.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,9 @@ const Medium = ({ icon, title, avatar, actions, badges, unread, menu, ...props }
2626
<SidebarV2Item {...props} onFocus={handleFocus} onPointerEnter={handlePointerEnter}>
2727
<SidebarV2ItemAvatarWrapper>{avatar}</SidebarV2ItemAvatarWrapper>
2828
{icon}
29-
<SidebarV2ItemTitle unread={unread}>{title}</SidebarV2ItemTitle>
29+
<SidebarV2ItemTitle unread={unread} title={typeof title === 'string' ? title : undefined}>
30+
{title}
31+
</SidebarV2ItemTitle>
3032
{badges}
3133
{actions}
3234
{menu && (

apps/meteor/tests/e2e/sidebar.spec.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,11 @@ test.describe.serial('Sidebar', () => {
102102
expect(isExpanded).toBeTruthy();
103103
});
104104

105+
test('should display full channel name on hover via tooltip', async () => {
106+
const item = poHomeChannel.sidebar.getSidebarItemByName(targetChannel);
107+
await expect(item.locator(`[title="${targetChannel}"]`)).toBeAttached();
108+
});
109+
105110
test('should expand/collapse sidebar groups with keyboard', async ({ page }) => {
106111
await page.goto('/home');
107112

0 commit comments

Comments
 (0)