hotfix(proxy): rename parameters for Net.NetworkCredential (#3483)

jorgheymans · r15ch13 · commit 1ac8ac0c6506 · 2019-05-29T18:48:12.000+02:00
close #3471
diff --git a/lib/core.ps1 b/lib/core.ps1
@@ -100,7 +100,7 @@ function setup_proxy() {
             [net.webrequest]::defaultwebproxy.credentials = [net.credentialcache]::defaultcredentials
         } elseif($credentials) {
             $username, $password = $credentials -split '(?<!\\):' | ForEach-Object { $_ -replace '\\([@:])','$1' }
-            [net.webrequest]::defaultwebproxy.credentials = new-object net.networkcredential($user, $pass)
+            [net.webrequest]::defaultwebproxy.credentials = new-object net.networkcredential($username, $password)
         }
     } catch {
         warn "Failed to use proxy '$proxy': $($_.exception.message)"

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ function setup_proxy() {`
`100`	`100`	`[net.webrequest]::defaultwebproxy.credentials = [net.credentialcache]::defaultcredentials`
`101`	`101`	`} elseif($credentials) {`
`102`	`102`	`$username, $password = $credentials -split '(?<!\\):' \| ForEach-Object { $_ -replace '\\([@:])','$1' }`
`103`		`- [net.webrequest]::defaultwebproxy.credentials = new-object net.networkcredential($user, $pass)`
	`103`	`+ [net.webrequest]::defaultwebproxy.credentials = new-object net.networkcredential($username, $password)`
`104`	`104`	`}`
`105`	`105`	`} catch {`
`106`	`106`	`warn "Failed to use proxy '$proxy': $($_.exception.message)"`