fix(autoupdate): Copy PSCustomObject-type properties within autoupdate to prevent reference changes (#5934)

amorphobia · niheaven · commit 5c411f380002 · 2024-05-13T18:36:38.000+08:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ### Bug Fixes
 
 - **scoop-search:** Catch error of parsing invalid manifest ([#5930](https://github.com/ScoopInstaller/Scoop/issues/5930))
+- **autoupdate:** Copy `PSCustomObject`-type properties within `autoupdate` to prevent reference changes ([#5934](https://github.com/ScoopInstaller/Scoop/issues/5934))
 
 ## [v0.4.1](https://github.com/ScoopInstaller/Scoop/compare/v0.4.0...v0.4.1) - 2024-04-25
 
diff --git a/lib/autoupdate.ps1 b/lib/autoupdate.ps1
@@ -365,7 +365,7 @@ function Update-ManifestProperty {
                 }
             } elseif ($Manifest.$currentProperty -and $Manifest.autoupdate.$currentProperty) {
                 # Update other property (global)
-                $autoupdateProperty = $Manifest.autoupdate.$currentProperty
+                $autoupdateProperty = $Manifest.autoupdate.$currentProperty.PSObject.Copy()
                 $newValue = substitute $autoupdateProperty $Substitutions
                 if (($autoupdateProperty.GetType().Name -eq 'Object[]') -and ($autoupdateProperty.Length -eq 1)) {
                     # Make sure it's an array

Original file line number	Diff line number	Diff line change
`@@ -365,7 +365,7 @@ function Update-ManifestProperty {`
`365`	`365`	`}`
`366`	`366`	`} elseif ($Manifest.$currentProperty -and $Manifest.autoupdate.$currentProperty) {`
`367`	`367`	`# Update other property (global)`
`368`		`- $autoupdateProperty = $Manifest.autoupdate.$currentProperty`
	`368`	`+ $autoupdateProperty = $Manifest.autoupdate.$currentProperty.PSObject.Copy()`
`369`	`369`	`$newValue = substitute $autoupdateProperty $Substitutions`
`370`	`370`	`if (($autoupdateProperty.GetType().Name -eq 'Object[]') -and ($autoupdateProperty.Length -eq 1)) {`
`371`	`371`	`# Make sure it's an array`