Skip to content

Commit 8619ee7

Browse files
feat(uninstall): Show the running processes (#5102)
* feat(install): show the running process * docs(CHANGELOG): Update changelog * perf(install): Show process-name in table format * Update lib/install.ps1 Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com> * Update lib/install.ps1 Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com> Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com>
1 parent bd12393 commit 8619ee7

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
- **scoop-(un)hold:** Support `scoop (un)hold scoop` ([#5089](https://github.com/ScoopInstaller/Scoop/issues/5089))
66
- **scoop-update:** Stash uncommitted changes before update ([#5091](https://github.com/ScoopInstaller/Scoop/issues/5091))
7+
- **install:** Show the running process ([#5102](https://github.com/ScoopInstaller/Scoop/issues/5102))
78

89
## [v0.2.4](https://github.com/ScoopInstaller/Scoop/compare/v0.2.3...v0.2.4) - 2022-08-08
910

lib/install.ps1

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1231,14 +1231,16 @@ function persist_permission($manifest, $global) {
12311231
# test if there are running processes
12321232
function test_running_process($app, $global) {
12331233
$processdir = appdir $app $global | Convert-Path
1234-
$running_processes = Get-Process | Where-Object { $_.Path -like "$processdir\*" }
1234+
$running_processes = Get-Process | Where-Object { $_.Path -like "$processdir\*" } | Out-String
12351235

12361236
if ($running_processes) {
12371237
if (get_config 'ignore_running_processes') {
1238-
warn "Application `"$app`" is still running. Scoop is configured to ignore this condition."
1238+
warn "The following instances of `"$app`" are still running. Scoop is configured to ignore this condition."
1239+
Write-Host $running_processes
12391240
return $false
12401241
} else {
1241-
error "Application `"$app`" is still running. Close all instances and try again."
1242+
error "The following instances of `"$app`" are still running. Close them and try again."
1243+
Write-Host $running_processes
12421244
return $true
12431245
}
12441246
} else {

0 commit comments

Comments
 (0)