chore(git): Remove unnecessary git_proxy_cmd() calls for local commands

Author: r15ch13

bin/scoop.ps1

@@ -22,15 +22,15 @@ $commands = commands
 if ('--version' -contains $cmd -or (!$cmd -and '-v' -contains $args)) {
     Push-Location $(versiondir 'scoop' 'current')
     write-host "Current Scoop version:"
-    git_log --oneline HEAD -n 1
+    Invoke-Expression "git --no-pager log --oneline HEAD -n 1"
     write-host ""
     Pop-Location
 
     Get-LocalBucket | ForEach-Object {
         Push-Location (Find-BucketDirectory $_ -Root)
         if(test-path '.git') {
             write-host "'$_' bucket:"
-            git_log --oneline HEAD -n 1
+            Invoke-Expression "git --no-pager log --oneline HEAD -n 1"
             write-host ""
         }
         Pop-Location

lib/buckets.ps1

@@ -128,7 +128,7 @@ function new_issue_msg($app, $bucket, $title, $body) {
 
     if (Test-path $bucket_path) {
         Push-Location $bucket_path
-        $remote = git_config --get remote.origin.url
+        $remote = Invoke-Expression "git config --get remote.origin.url"
         # Support ssh and http syntax
         # git@PROVIDER:USER/REPO.git
         # https://PROVIDER/USER/REPO.git

lib/git.ps1

@@ -19,10 +19,6 @@ function git_checkout {
     git_proxy_cmd checkout $args
 }
 
-function git_branch {
-    git_proxy_cmd branch $args
-}
-
 function git_pull {
     git_proxy_cmd pull $args
 }
@@ -31,22 +27,6 @@ function git_fetch {
     git_proxy_cmd fetch $args
 }
 
-function git_log {
-    git_proxy_cmd --no-pager log $args
-}
-
 function git_checkout {
     git_proxy_cmd checkout $args
 }
-
-function git_branch {
-    git_proxy_cmd branch $args
-}
-
-function git_config {
-    git_proxy_cmd config $args
-}
-
-function git_reset {
-    git_proxy_cmd reset $args
-}

libexec/scoop-update.ps1

@@ -92,26 +92,27 @@ function update_scoop() {
         Push-Location $currentdir
 
         $currentRepo = git_config remote.origin.url
-        $currentBranch = git_branch
+        $currentRepo = Invoke-Expression "git config remote.origin.url"
+        $currentBranch = Invoke-Expression "git branch"
 
         $isRepoChanged = !($currentRepo -match $configRepo)
         $isBranchChanged = !($currentBranch -match "\*\s+$configBranch")
 
         # Change remote url if the repo is changed
         if ($isRepoChanged) {
-            git_config remote.origin.url "$configRepo"
+            Invoke-Expression "git config remote.origin.url '$configRepo'"
         }
 
         # Fetch and reset local repo if the repo or the branch is changed
         if ($isRepoChanged -or $isBranchChanged) {
             # Reset git fetch refs, so that it can fetch all branches (GH-3368)
-            git_config remote.origin.fetch "+refs/heads/*:refs/remotes/origin/*"
+            Invoke-Expression "git config remote.origin.fetch '+refs/heads/*:refs/remotes/origin/*'"
             # fetch remote branch
             git_fetch --force origin "refs/heads/`"$configBranch`":refs/remotes/origin/$configBranch" -q
             # checkout and track the branch
             git_checkout -B $configBranch -t origin/$configBranch -q
             # reset branch HEAD
-            git_reset --hard origin/$configBranch -q
+            Invoke-Expression "git reset --hard origin/$configBranch -q"
         } else {
             git_pull -q
         }