fix(shim): Avoid unexpected output of list subcommand

lewis-yeung · lewis-yeung · commit 9db2df5ce171 · 2023-10-09T20:45:14.000+08:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -35,6 +35,7 @@
 - **scoop-checkup:** Change the message level of helpers from ERROR to WARN ([#5549](https://github.com/ScoopInstaller/Scoop/issues/5614))
 - **scoop-(un)hold:** Correct output the messages when manifest not found, (already|not) held ([#5519](https://github.com/ScoopInstaller/Scoop/issues/5519))
 - **scoop-update:** Change error message to a better instruction ([#5677](https://github.com/ScoopInstaller/Scoop/issues/5677))
+- **shim:** Avoid unexpected output of `list` subcommand ([#5681](https://github.com/ScoopInstaller/Scoop/issues/5681))
 
 ### Performance Improvements
 
diff --git a/libexec/scoop-shim.ps1 b/libexec/scoop-shim.ps1
@@ -12,7 +12,7 @@
 #
 # To list all shims or matching shims, use the 'list' subcommand:
 #
-#     scoop shim list [<shim_name>/<pattern>...]
+#     scoop shim list [<shim_name>/<regex_pattern>...]
 #
 # To show a shim's information, use the 'info' subcommand:
 #
@@ -144,7 +144,7 @@ switch ($SubCommand) {
         $other | ForEach-Object {
             try {
                 $pattern = $_
-                [Regex]::New($pattern)
+                [void][Regex]::New($pattern)
             } catch {
                 Write-Host "ERROR: Invalid pattern: " -ForegroundColor Red -NoNewline
                 Write-Host $pattern -ForegroundColor Magenta

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`#`
`13`	`13`	`# To list all shims or matching shims, use the 'list' subcommand:`
`14`	`14`	`#`
`15`		`-# scoop shim list [<shim_name>/<pattern>...]`
	`15`	`+# scoop shim list [<shim_name>/<regex_pattern>...]`
`16`	`16`	`#`
`17`	`17`	`# To show a shim's information, use the 'info' subcommand:`
`18`	`18`	`#`
`@@ -144,7 +144,7 @@ switch ($SubCommand) {`
`144`	`144`	`$other \| ForEach-Object {`
`145`	`145`	`try {`
`146`	`146`	`$pattern = $_`
`147`		`- [Regex]::New($pattern)`
	`147`	`+ [void][Regex]::New($pattern)`
`148`	`148`	`} catch {`
`149`	`149`	`Write-Host "ERROR: Invalid pattern: " -ForegroundColor Red -NoNewline`
`150`	`150`	`Write-Host $pattern -ForegroundColor Magenta`