fix(get-manfest): Add back '$appPath' (#4981)

niheaven · web-flow · commit 9e70dcad7924 · 2022-06-10T22:31:43.000+08:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -25,7 +25,7 @@
 
 ### Code Refactoring
 
-- **manifest:** Rename 'Find-Manifest()' to 'Get-Manifest() ([#4966](https://github.com/ScoopInstaller/Scoop/issues/4966))
+- **manifest:** Rename 'Find-Manifest()' to 'Get-Manifest() ([#4966](https://github.com/ScoopInstaller/Scoop/issues/4966), [#4981](https://github.com/ScoopInstaller/Scoop/issues/4981))
 
 ### Documentation
 
diff --git a/lib/manifest.ps1 b/lib/manifest.ps1
@@ -43,11 +43,12 @@ function Get-Manifest($app) {
         }
         if (!$manifest) {
             # couldn't find app in buckets: check if it's a local path
-            if (!$app.EndsWith('.json')) {
-                $app += '.json'
+            $appPath = $app
+            if (!$appPath.EndsWith('.json')) {
+                $appPath += '.json'
             }
-            if (Test-Path $app) {
-                $url = Convert-Path $app
+            if (Test-Path $appPath) {
+                $url = Convert-Path $appPath
                 $app = appname_from_url $url
                 $manifest = url_manifest $url
             }

Original file line number	Diff line number	Diff line change
`@@ -43,11 +43,12 @@ function Get-Manifest($app) {`
`43`	`43`	`}`
`44`	`44`	`if (!$manifest) {`
`45`	`45`	`# couldn't find app in buckets: check if it's a local path`
`46`		`- if (!$app.EndsWith('.json')) {`
`47`		`- $app += '.json'`
	`46`	`+ $appPath = $app`
	`47`	`+ if (!$appPath.EndsWith('.json')) {`
	`48`	`+ $appPath += '.json'`
`48`	`49`	`}`
`49`		`- if (Test-Path $app) {`
`50`		`- $url = Convert-Path $app`
	`50`	`+ if (Test-Path $appPath) {`
	`51`	`+ $url = Convert-Path $appPath`
`51`	`52`	`$app = appname_from_url $url`
`52`	`53`	`$manifest = url_manifest $url`
`53`	`54`	`}`