Skip to content

Commit c6fc2de

Browse files
authored
fix(buckets): Don't write message OK before bucket is cloned (#4925)
1 parent a2600b1 commit c6fc2de

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
### Bug Fixes
44

55
- **bucket:** Don't check remote URL of non-git buckets ([#4923](https://github.com/ScoopInstaller/Scoop/issues/4923))
6+
- **bucket:** Don't write message OK before bucket is cloned ([#4925](https://github.com/ScoopInstaller/Scoop/issues/4925))
67

78
## [v0.2.0](https://github.com/ScoopInstaller/Scoop/compare/v0.1.0...v0.2.0) - 2022-05-10
89

lib/buckets.ps1

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,11 +177,10 @@ function add_bucket($name, $repo) {
177177
error "'$repo' doesn't look like a valid git repository`n`nError given:`n$out"
178178
return 1
179179
}
180-
Write-Host 'OK'
181-
182180
ensure $bucketsdir | Out-Null
183181
$dir = ensure $dir
184182
git_cmd clone "$repo" "`"$dir`"" -q
183+
Write-Host 'OK'
185184
success "The $name bucket was added successfully."
186185
return 0
187186
}

0 commit comments

Comments
 (0)