fix(sqlite): select latest search result semantically

Author: B67687

lib/database.ps1

@@ -1,5 +1,52 @@
 # Description: Functions for interacting with the Scoop database cache
 
+if (-not (Get-Command Compare-Version -ErrorAction Ignore)) {
+    . "$PSScriptRoot\versions.ps1"
+}
+
+function Get-LatestScoopDBRow {
+    param(
+        [Parameter(Mandatory)]
+        [object[]]
+        $Rows
+    )
+
+    $latest = $Rows[0]
+    foreach ($row in ($Rows | Select-Object -Skip 1)) {
+        if ((Compare-Version -ReferenceVersion $latest.version -DifferenceVersion $row.version) -gt 0) {
+            $latest = $row
+        }
+    }
+
+    return $latest
+}
+
+function Select-LatestScoopDBRows {
+    param(
+        [Parameter(Mandatory)]
+        [System.Data.DataTable]
+        $Table,
+        [string[]]
+        $GroupBy
+    )
+
+    $latestRows = $Table.Clone()
+    $rows = @($Table.Rows)
+    if ($rows.Count -eq 0) {
+        return $latestRows
+    }
+
+    if ($GroupBy -and $GroupBy.Count -gt 0) {
+        foreach ($group in ($rows | Group-Object -Property $GroupBy)) {
+            $latestRows.ImportRow((Get-LatestScoopDBRow -Rows @($group.Group)))
+        }
+    } else {
+        $latestRows.ImportRow((Get-LatestScoopDBRow -Rows $rows))
+    }
+
+    return $latestRows
+}
+
 <#
 .SYNOPSIS
     Get SQLite .NET driver
@@ -253,7 +300,6 @@ function Select-ScoopDBItem {
         $dbAdapter = New-Object -TypeName System.Data.SQLite.SQLiteDataAdapter
         $result = New-Object System.Data.DataTable
         $dbQuery = "SELECT * FROM app WHERE $(($From -join ' LIKE @Pattern OR ') + ' LIKE @Pattern')"
-        $dbQuery = "SELECT * FROM ($($dbQuery + ' ORDER BY version DESC')) GROUP BY name, bucket"
         $dbCommand = $db.CreateCommand()
         $dbCommand.CommandText = $dbQuery
         $dbCommand.CommandType = [System.Data.CommandType]::Text
@@ -266,7 +312,7 @@ function Select-ScoopDBItem {
     end {
         $dbAdapter.Dispose()
         $db.Dispose()
-        return $result
+        return Select-LatestScoopDBRows -Table $result -GroupBy @('name', 'bucket')
     }
 }
 
@@ -311,8 +357,6 @@ function Get-ScoopDBItem {
         $dbQuery = 'SELECT * FROM app WHERE name = @Name AND bucket = @Bucket'
         if ($Version) {
             $dbQuery += ' AND version = @Version'
-        } else {
-            $dbQuery += ' ORDER BY version DESC LIMIT 1'
         }
         $dbCommand = $db.CreateCommand()
         $dbCommand.CommandText = $dbQuery
@@ -328,7 +372,11 @@ function Get-ScoopDBItem {
     end {
         $dbAdapter.Dispose()
         $db.Dispose()
-        return $result
+        if ($Version) {
+            return $result
+        }
+
+        return Select-LatestScoopDBRows -Table $result
     }
 }
 

test/Scoop-Database.Tests.ps1

@@ -0,0 +1,53 @@
+Describe 'database version selection' -Tag 'Scoop' {
+    BeforeAll {
+        . "$PSScriptRoot\Scoop-TestLib.ps1"
+        . "$PSScriptRoot\..\lib\core.ps1"
+        . "$PSScriptRoot\..\lib\versions.ps1"
+        . "$PSScriptRoot\..\lib\database.ps1"
+    }
+
+    It 'chooses the semantically latest row within one result set' {
+        $rows = @(
+            [pscustomobject]@{ version = '1.0.7' }
+            [pscustomobject]@{ version = '1.0.31' }
+        )
+
+        (Get-LatestScoopDBRow -Rows $rows).version | Should -Be '1.0.31'
+    }
+
+    It 'returns the latest semantic version per name and bucket' {
+        $result = New-Object System.Data.DataTable
+        [void]$result.Columns.Add('name', [string])
+        [void]$result.Columns.Add('version', [string])
+        [void]$result.Columns.Add('bucket', [string])
+        [void]$result.Columns.Add('binary', [string])
+        [void]$result.Rows.Add('copilot-cli', '1.0.7', 'main', 'copilot')
+        [void]$result.Rows.Add('copilot-cli', '1.0.31', 'main', 'copilot')
+        [void]$result.Rows.Add('zotero', '7.0.9', 'extras', 'zotero')
+        [void]$result.Rows.Add('zotero', '7.0.20', 'extras', 'zotero')
+        [void]$result.Rows.Add('zotero', '7.0.9', 'he0119', 'zotero')
+        [void]$result.Rows.Add('zotero', '7.0.20', 'he0119', 'zotero')
+
+        $latest = @(Select-LatestScoopDBRows -Table $result -GroupBy @('name', 'bucket'))
+
+        $latest.Count | Should -Be 3
+        (@($latest | Where-Object { $_.name -eq 'copilot-cli' -and $_.bucket -eq 'main' })[0]).version | Should -Be '1.0.31'
+        (@($latest | Where-Object { $_.name -eq 'zotero' -and $_.bucket -eq 'extras' })[0]).version | Should -Be '7.0.20'
+        (@($latest | Where-Object { $_.name -eq 'zotero' -and $_.bucket -eq 'he0119' })[0]).version | Should -Be '7.0.20'
+    }
+
+    It 'returns the latest semantic version when no grouping is requested' {
+        $result = New-Object System.Data.DataTable
+        [void]$result.Columns.Add('name', [string])
+        [void]$result.Columns.Add('version', [string])
+        [void]$result.Columns.Add('bucket', [string])
+        [void]$result.Columns.Add('binary', [string])
+        [void]$result.Rows.Add('zotero', '7.0.9', 'extras', 'zotero')
+        [void]$result.Rows.Add('zotero', '7.0.20', 'extras', 'zotero')
+
+        $latest = @(Select-LatestScoopDBRows -Table $result)
+
+        $latest.Count | Should -Be 1
+        $latest[0].version | Should -Be '7.0.20'
+    }
+}