Fix: 'scoop cache' command not using SCOOP_CACHE#1990
Merged
r15ch13 merged 1 commit intoScoopInstaller:masterfrom Jan 28, 2018
Merged
Fix: 'scoop cache' command not using SCOOP_CACHE#1990r15ch13 merged 1 commit intoScoopInstaller:masterfrom
r15ch13 merged 1 commit intoScoopInstaller:masterfrom
Conversation
brandon93s
approved these changes
Jan 28, 2018
rasa
approved these changes
Jan 28, 2018
Member
|
Good one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this was just overlooked?
scoop-cache.ps1doesn't use the$cachedirvariable, so it doesn't get the SCOOP_CACHE support added in #1364.The result being that while the install command correctly uses the folder in SCOOP_CACHE, all scoop cache ... commands error because they can't find a
...scoop\cachefolder.