Fix .ps1 shim parsing logic due to my prior PR#2564
Merged
r15ch13 merged 3 commits intoScoopInstaller:masterfrom Sep 7, 2018
leonyu:fix-and-test-warn_on_overwrite
Merged
Fix .ps1 shim parsing logic due to my prior PR#2564r15ch13 merged 3 commits intoScoopInstaller:masterfrom leonyu:fix-and-test-warn_on_overwrite
r15ch13 merged 3 commits intoScoopInstaller:masterfrom
leonyu:fix-and-test-warn_on_overwrite
Conversation
r15ch13
reviewed
Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to my prior PR #2562 which changed the content of .ps1 shims, the code that attempts to warn about shims being overwritten no longer detects app name correctly. This is to correct that.
Since now the path of the app can be on either first line or 2nd line, my implementation just assumes shims will be utf8 files and try to find first the app name in the first 1000 characters. This works for both the old shim and the new shim, and allow for some forward flexibility towards how shim code is written going forward.