[Checkver] Support skipping up to date manifests#2624
[Checkver] Support skipping up to date manifests#2624r15ch13 merged 11 commits intoScoopInstaller:masterfrom
Conversation
Ash258
changed the title
|
|
||
| write-host "$ver" -f darkred -nonewline | ||
| write-host " (scoop version is $expected_ver)" -NoNewline | ||
| $update_available = (compare_versions $expected_ver $ver) -eq -1 |
There was a problem hiding this comment.
$updateAvailable or $UpdateAvailable or $update_available. Combining snake_case and camelCase looks awkward 😁
There was a problem hiding this comment.
Wrong regex for rename all occurancies
There was a problem hiding this comment.
Why is there this $update_available check? You already know, there is version mismatch if you use $ver -eq $expected_ver
There was a problem hiding this comment.
It is only to determine if it's upgrade or downgrade?
There was a problem hiding this comment.
Hm, it's pretty much the cause of automated downgrades, now that I think about it.
compare_versions should be used instead of $ver -eq $expected_ver, I guess.
|
Anything else need to be added / fixed. Do you need any help with wiki or something else? |
2 participants
Further testing is welcomed and required i think.
How it look: