Skip to content

Fixed persisting bug when force update app with same version.#2774

Merged
rasa merged 1 commit intoScoopInstaller:masterfrom
pakornv:fix-update-command
Dec 6, 2018
Merged

Fixed persisting bug when force update app with same version.#2774
rasa merged 1 commit intoScoopInstaller:masterfrom
pakornv:fix-update-command

Conversation

@pakornv
Copy link
Copy Markdown
Contributor

@pakornv pakornv commented Nov 15, 2018

Relate issue : #2724

@Ash258
Copy link
Copy Markdown
Contributor

Ash258 commented Nov 16, 2018

Fix persisting files, which was broken in your previous PR. #2732 (comment)

proof

@pakornv
Copy link
Copy Markdown
Contributor Author

pakornv commented Nov 17, 2018

Could you explain to me. Which package was broken.

@Ash258
Copy link
Copy Markdown
Contributor

Ash258 commented Nov 17, 2018

Theoretically every manifest, which specify persist of file, which does not exists on persisting. In my custom UnrealCommander it happens even if I precreate that file.

When that file does not exists, it's automatically created as folder (Now). Before persisting failed, which is better for not messing up that file.

Fsviewer
Unreal

@rasa rasa merged commit ed6b10a into ScoopInstaller:master Dec 6, 2018
r15ch13 added a commit that referenced this pull request Dec 6, 2018
@pakornv pakornv deleted the fix-update-command branch January 26, 2019 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants