Skip to content

Support soft/purge uninstalling of scoop itself#2781

Merged
r15ch13 merged 6 commits intoScoopInstaller:masterfrom
Ash258:purge-uninstall
Mar 25, 2019
Merged

Support soft/purge uninstalling of scoop itself#2781
r15ch13 merged 6 commits intoScoopInstaller:masterfrom
Ash258:purge-uninstall

Conversation

@Ash258
Copy link
Copy Markdown
Contributor

@Ash258 Ash258 commented Nov 17, 2018

Why there is this code block?
https://github.com/lukesampson/scoop/blob/70bd6ae8c0f979924f85b9357a546859bd351553/libexec/scoop-uninstall.ps1#L26
I haven't found use case, which fires it.
- Should not it be here?
https://github.com/lukesampson/scoop/blob/70bd6ae8c0f979924f85b9357a546859bd351553/libexec/scoop-uninstall.ps1#L37

  1. ENV in tested VM
    • Windows 10 PRO RS5 (1809 17763.1)
    • ENV
  2. Scoop uninstall Total Commander
    1. Local
      1. Soft
        Soft
      2. Purge
        Purge
    2. Global
      1. Soft
        Soft
      2. Purge
        Purge
  3. Scoop uninstall Scoop
    1. Local
      1. Soft
        Soft
      2. Purge
        Purge
    2. Global
      1. Soft
        Soft
      2. Purge
        Purge

@Ash258 Ash258 changed the title Purge uninstall Support soft/purge uninstalling of scoop itself Nov 17, 2018
@r15ch13
Copy link
Copy Markdown
Member

r15ch13 commented Nov 19, 2018

https://github.com/lukesampson/scoop/blob/70bd6ae8c0f979924f85b9357a546859bd351553/libexec/scoop-uninstall.ps1#L26
This one checks if the apps parameter is set. scoop uninstall without an app name should trigger it.

https://github.com/lukesampson/scoop/blob/70bd6ae8c0f979924f85b9357a546859bd351553/libexec/scoop-uninstall.ps1#L37
This one checks if the result of ensure_all_installed() isn't empty.

Looks good to me. @rasa @brandon93s

@r15ch13 r15ch13 merged commit d8d1400 into ScoopInstaller:master Mar 25, 2019
@Ash258 Ash258 deleted the purge-uninstall branch March 25, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants