Allowed underscores in package names.#2930
Merged
r15ch13 merged 2 commits intoScoopInstaller:masterfrom Feb 22, 2019
Merged
Conversation
Member
|
Please add a test case to https://github.com/lukesampson/scoop/blob/master/test/Scoop-Core.Tests.ps1#L258 |
Contributor
Author
|
Okay. |
excitoon
force-pushed
the
allowed-underscore-in-package-names
branch
from
7eaf600 to
41a11d5
Compare
excitoon
force-pushed
the
allowed-underscore-in-package-names
branch
from
41a11d5 to
eac2526
Compare
Contributor
Author
|
@r15ch13 I'm finally finished it. Please check if it is fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example:
gcc-x86_64(this is not host architecture, which can be expressed by-a, but target one).