buckets: Move function into lib from lib-exec#3062
Merged
r15ch13 merged 2 commits intoScoopInstaller:masterfrom Feb 1, 2019
Merged
buckets: Move function into lib from lib-exec#3062r15ch13 merged 2 commits intoScoopInstaller:masterfrom
r15ch13 merged 2 commits intoScoopInstaller:masterfrom
Conversation
There is no reason to have it inside lib-exec since, it's all internal functions, which could be used inside other code lib-exec scripts should be slimmed as possible, as they are only code runners with some validation
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no reason to have it inside lib-exec since, it's all internal functions, which could be used inside other code
list_bucketsfunction.bucketslib-exec scripts should be slimmed as possible, as they are only code runners with some validation