decompress.ps1: Refactored (w/ install.ps1, core.ps1) (edited)

[niheaven]

EDITED: Split PR, PART I

• Move Functions (to decompress.ps1)
  • extract_zip and unzip_old from core.ps1
  • unpack_inno, extract_msi, lessmsi_config and extract_lessmsi from install.ps1
• Modify Test
  • Move unzip_old test from Scoop-Core.Tests.ps1 to Scoop-Decompress.Tests.ps1

Thanks for @Ash258 #3149, this could be part of it.

[Ash258]

I would rather see 3 PRs for each list item (instead of 1 huge) in small iteration windows. This increase error domain and could be hard to debug. So:

1. Move functions
   • Review
   • Merge
   • Wait for feedback of users (few days)
   • Repeat for next item

[niheaven]

Split PR and this is the one for moving function.

Other fix (rewrite functions, etc.) will be submitted after merged.

@Ash258 @r15ch13 @rasa

[r15ch13]

Working and ready for merge? Can't test right now.

[Ash258]

I am not sure if this change do not break installation of new scoop. Since only core is downloaded and extract_zip is called (https://github.com/lukesampson/scoop/blob/master/bin/install.ps1#L49)

@niheaven Have you tested installation?

[Ash258]

These "hacks" and continuality thinking about not breaking installation will not be needed when bucket extraction and standalone installer (https://github.com/scoopinstaller/install) is done and is not dependent on scoop's core implementation.

[niheaven]

@Ash258 @r15ch13 Fully tested with last commit.

Replace extract_zip with .NET's [IO.Compression.ZipFile]::ExtractToDirectory() in bin/install.ps1. Since requirement of Powershell is 3+, Expand-Archive introduced in PS 5 cannot be used (which should be better).

This PR can be tested by the following code:

[environment]::setEnvironmentVariable('SCOOP','D:\TEST_SCOOP_PATH','User')
$env:SCOOP='D:\TEST_SCOOP_PATH\Scoop'
iex (new-object net.webclient).downloadstring('https://raw.githubusercontent.com/niheaven/scoop/test-scoop/bin/install.ps1')
scoop config SCOOP_REPO "https://github.com/niheaven/scoop"
scoop config SCOOP_BRANCH "refactor-decompress"
scoop update
scoop install ag

test-scoop/bin/install.ps1 is a modified install script that redirect to PR's branch, and scoop update, scoop install ag(zip installer) both okay.

I've test above code with Unicode path (测试\Scoop), long path (looooooooooooooooooooooooooooooooooooooooongpaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaath\Scoop)
of 'TEST_SCOOP_PATH', etc., and all passed.

Please remember to restore scoop config and env values after test.

[Ash258]

LGTM. By static code review. Will fully test it in few minutes, after i arrive home.

[niheaven]

The new scoop installer uses the same method that I used here, and Expand-Archive for PS 5+, too.

[niheaven]

@Ash258 Does the test be passed?

[Ash258]

LGTM

[Ash258]

Tested basic scoop installation, manifest installation / updating.