Refactor function names and fix installing 7zip locally if already globally available#3416
Merged
Refactor function names and fix installing 7zip locally if already globally available#3416
Conversation
7zip_path -> Get-7zipPath 7zip_installed -> Test-7zipInstalled Expand-7ZipArchive -> Expand-7zipArchive Test-7ZipRequirement -> Test-7zipRequirement Expand-MSIArchive -> Expand-MsiArchive Test-LessMSIRequirement -> Test-LessmsiRequirement
aria2_path > Get-Aria2Path aria2_installed > Test-Aria2Installed aria2_enabled > Test-Aria2Enabled
…g dependency Prevents installing 7zip/lessmsi/innounp locally if they are already available globally
Member
Author
Member
|
Consider PS. I could test it tomorrow~ |
Member
Author
|
Since these are essential for Scoop to work, I would rather not use external versions because these can cause issues. Older 7zip versions have already caused some issues. |
Member
|
Okay, got it. Since |
Member
& (Get-7zipPath) x "$Path" -o"$DestinationPath" (-split $Switches) -y | Out-File $LogLocationAbove cmd works, and I suggest changing them so, for further scoop refactoring. |
niheaven
reviewed
Apr 30, 2019
r15ch13
added a commit
that referenced
this pull request
May 12, 2019
- The main bucket of Scoop has been separated to https://github.com/ScoopInstaller/Main - Requires PowerShell 5 and newer #3330 - Improve and refactor decompression functions #3204 #3409 #3411 - Move scoop config from `~\.scoop` to `~\.config\scoop\config.json` #3242 - Add `scoop hold` and `scoop unhold` for excluding programs from updates #3444 - Refactored some Core functions #3314 #3416 - Small fix for starting processes on Windows 7 #3415 Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com> Co-authored-by: Chawye Hsu <h404bi@outlook.com> Co-authored-by: Jakub Čábera <cabera.jakub@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Additions:
Get-HelperPathTest-HelperInstalledGet-LessmsiPathGet-HelperPath -Helper LessmsiTest-LessmsiInstalledTest-HelperInstalled -Helper LessmsiGet-InnounpPathGet-HelperPath -Helper InnounpTest-InnounpInstalledTest-HelperInstalled -Helper InnounpGet-HelperPath -Helper DarkTest-HelperInstalled -Helper DarkAdded tests for:
Get-AppFilePathGet-HelperPathTest-HelperInstalledTest-Aria2EnabledTest-CommandAvailableRefactors:
aria2_path>Get-HelperPath -Helper Aria2aria2_installed>Test-HelperInstalled -Helper Aria2aria2_enabled>Test-Aria2Enabled7zip_path>Get-HelperPath -Helper 7zip7zip_installed>Test-HelperInstalled -Helper 7zipExpand-7ZipArchive>Expand-7zipArchiveTest-7ZipRequirement>Test-7zipRequirementExpand-MSIArchive>Expand-MsiArchiveTest-LessMSIRequirement>Test-LessmsiRequirementfile_path>Get-AppFilePath