refactor(core): Add more generic 'Invoke-ExternalCommand' instead of 'run'#3432
Merged
r15ch13 merged 1 commit intoScoopInstaller:developfrom May 15, 2019
Merged
refactor(core): Add more generic 'Invoke-ExternalCommand' instead of 'run'#3432r15ch13 merged 1 commit intoScoopInstaller:developfrom
r15ch13 merged 1 commit intoScoopInstaller:developfrom
Conversation
Contributor
|
I do not see deprecation message for |
Member
Author
|
Isn't it a pure internal function? 😅 Add backward compatible for |
Member
Author
|
niheaven
force-pushed
the
refactor-run
branch
2 times, most recently
from
1cf4a9c to
b28b363
Compare
This was referenced May 13, 2019
niheaven
changed the title
r15ch13
pushed a commit
that referenced
this pull request
Jun 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
runininstall.ps1Invoke-ExternalCommandand move tocore.ps1Invoke-ExternalCommandto refactorExpand-7zipArchive,Expand-MsiArchive,Expand-InnoArchiveTODO in next PR: Refactor
Expand-XXXArchiveto use an universal interface, just asGet-HelperPath, for further extending.