fix(decompress): '$ExtractDir' error with '.zip' and subdir#3472
Merged
r15ch13 merged 1 commit intoScoopInstaller:developfrom May 17, 2019
Merged
fix(decompress): '$ExtractDir' error with '.zip' and subdir#3472r15ch13 merged 1 commit intoScoopInstaller:developfrom
r15ch13 merged 1 commit intoScoopInstaller:developfrom
Conversation
r15ch13
pushed a commit
that referenced
this pull request
Jun 24, 2019
For some `extract_dir` in .zip that has sub-dir, the former one would remove parent dir and get error (flac, flac-1.3.2-win\win64), now use temp dir instead. And also fix .msi, in case of some installer that don't have `SourceDir`. `Expand-DarkArchive` will be used in wix extraction, so it doesn't need `-ExtractDir`. `Expand-7zipArchive` and `Expand-InnoArchive` works well. Tested: - calibre-normal (msi, PFiles\Calibre2) - flac (zip, flac-1.3.2-win\win64) - pkg-config (zip, multiple url and extract_dir) BTW, `Expand-Archive` has `-PassThru` param in PowerShell 6+, and it will be more convinient to support `-ExtractDir` with it. I'll check function's source code and plan to rewrite `Expand-ZipArchive`. Fix #3473, ref #3473 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for this 2nd fix...
For some
extract_dirin .zip that has sub-dir, the former one would remove parent dir and get error (flac, flac-1.3.2-win\win64), now use temp dir instead. And also fix .msi, in case of some installer that don't haveSourceDir.Expand-DarkArchivewill be used in wix extraction, so it doesn't need-ExtractDir.Expand-7zipArchiveandExpand-InnoArchiveworks well.Tested:
BTW,
Expand-Archivehas-PassThruparam in PowerShell 6+, and it will be more convinient to support-ExtractDirwith it. I'll check function's source code and plan to rewriteExpand-ZipArchive.Fix #3473, ref #3473 (comment)