fix(decompress): fix bugs on extract_dir#3540
Merged
r15ch13 merged 2 commits intoScoopInstaller:developfrom Jul 24, 2019
issaclin32:fix-decompress
Merged
fix(decompress): fix bugs on extract_dir#3540r15ch13 merged 2 commits intoScoopInstaller:developfrom issaclin32:fix-decompress
r15ch13 merged 2 commits intoScoopInstaller:developfrom
issaclin32:fix-decompress
Conversation
Contributor
|
Change base branch to develop |
Member
|
This would result in |
Member
Author
Changing it to |
|
I'd still really like to install ISLC some day 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the error when
extract_dircontains spaces, such as "ISLC v1.0.1.2"(encountered in: ScoopInstaller/Extras#2398)
Please let me know if there are any problems. Thanks.