fix(autoupdate): Decode basename when extract hash#3615
Merged
r15ch13 merged 1 commit intoScoopInstaller:developfrom Oct 14, 2019
linsui:basename
Merged
fix(autoupdate): Decode basename when extract hash#3615r15ch13 merged 1 commit intoScoopInstaller:developfrom linsui:basename
r15ch13 merged 1 commit intoScoopInstaller:developfrom
linsui:basename
Conversation
Contributor
|
What does have basename string to do with hash extraction templates?? Do not add it into hash templates |
Contributor
Author
|
substitutions will be regexEscape. |
linsui
changed the title
Contributor
|
Would not be more suitable to url decode it rather than specifiing all possible escapes?
Relate ScoopInstaller/Main#471 |
Contributor
Author
|
Good idea! Would you pr? Then I'll close this. |
Member
Why not update your pull request? |
Contributor
Author
|
I don't want to steal credit 😂 . If @Ash258 doesn't want to open another pr I'm glad to update this. |
Member
Contributor
Author
|
Thanks! I'll have a try. |
Contributor
|
I do not care for contributions. Edit this PR. |
Co-authored-by: Jakub Čábera <cabera.jakub@gmail.com>
linsui
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefox, Thunderbird and uget can benefit.