fix(scoop-info): check bucket of installed app#3740
Merged
r15ch13 merged 3 commits intoScoopInstaller:developfrom Dec 2, 2019
linsui:info
Merged
fix(scoop-info): check bucket of installed app#3740r15ch13 merged 3 commits intoScoopInstaller:developfrom linsui:info
r15ch13 merged 3 commits intoScoopInstaller:developfrom
linsui:info
Conversation
linsui
changed the title
Ash258
suggested changes
Dec 2, 2019
Co-Authored-By: Jakub Čábera <cabera.jakub@gmail.com>
Ash258
approved these changes
Dec 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When bucket is specified, check if the installed app belong to the same bucket. If app is not installed from the specified bucket, output
Installed: NoAlso fix another bug. When an app hash is wrong there is no manifest.json in app directory. So
$install.bucketis none.Find-BucketDirectorywill return main bucket path as default andmanifest_pathwill return a wrong path.