feat: Add configuration option for default architecture#3778
Merged
r15ch13 merged 3 commits intoScoopInstaller:developfrom Dec 16, 2019
Merged
feat: Add configuration option for default architecture#3778r15ch13 merged 3 commits intoScoopInstaller:developfrom
r15ch13 merged 3 commits intoScoopInstaller:developfrom
Conversation
- Closes ScoopInstaller#3770 Configuration name is subject of change. I am following dash notation for naming, until config is reworked and united (Relateed ScoopInstaller#3401) Is boolean enough or it is prefered to go with `scoop config 'default-architecture' '32bit|64bit'` which could be more suitable for additional arch support (arm for example) 
Member
|
|
Member
|
|
Member
|
scoop should throw when user use some words other than |
Contributor
Author
|
I could potentially add else branch with ensure_architecture function check Resulting to: if ($null -eq $arch) {
if .... is64..
} else {
$arch = ensure_architecture $arch
}or to be more user friendly with something like this try {
$arch = ensure_architecture $arch
} catch {
error 'Invalid default architecture configured'
} |
Member
|
Prefer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configuration name is subject of change. I am following dash notation for naming, until config is reworked and united (Related #3401)
Is boolean enough or it is prefered to go withscoop config 'default-architecture' '32bit|64bit'which could be more suitable for additional arch support (arm for example)