Skip to content

fix(install): let pathes in 'env_add_path' be added ascendantly#3788

Merged
r15ch13 merged 3 commits intoScoopInstaller:developfrom
niheaven:fix-env_add_path
May 11, 2020
Merged

fix(install): let pathes in 'env_add_path' be added ascendantly#3788
r15ch13 merged 3 commits intoScoopInstaller:developfrom
niheaven:fix-env_add_path

Conversation

@niheaven
Copy link
Copy Markdown
Member

Fix #3785

Comment thread lib/install.ps1 Outdated
Co-Authored-By: Chawye Hsu <chawyehsu@hotmail.com>
Comment thread lib/install.ps1 Outdated
@Ash258
Copy link
Copy Markdown
Contributor

Ash258 commented Dec 16, 2019

Is there any possibility of breaking current behaviour? I cannot think about anything right now.

@niheaven
Copy link
Copy Markdown
Member Author

Just order in %PATH%, which shouldn't break anything. Maintainer typically write env_add_path ascendantly, I thought.

@chawyehsu
Copy link
Copy Markdown
Member

ping @r15ch13

@r15ch13 r15ch13 changed the title fix(install): let pathes in 'env_add_path' be added ascendantly fix(install): let pathes in 'env_add_path' be added ascendantly May 11, 2020
@r15ch13 r15ch13 merged commit f91968c into ScoopInstaller:develop May 11, 2020
@niheaven niheaven deleted the fix-env_add_path branch May 12, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants