fix(depends): Check if extractor is available#4042
Merged
niheaven merged 3 commits intoScoopInstaller:developfrom Jan 8, 2022
mgziminsky:patch-1
Merged
fix(depends): Check if extractor is available#4042niheaven merged 3 commits intoScoopInstaller:developfrom mgziminsky:patch-1
niheaven merged 3 commits intoScoopInstaller:developfrom
mgziminsky:patch-1
Conversation
AlfredtheServa1
previously approved these changes
Sep 20, 2020
Ash258
added a commit
to Ash258/Scoop-Core
that referenced
this pull request
Oct 28, 2020
rashil2000
dismissed
AlfredtheServa1’s stale review
The base branch was changed.
niheaven
changed the title
niheaven
approved these changes
Jan 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
script_depswasn't checking if helpers were already installed before adding them as a dependency. This could cause issues if you had any of the helpers installed globally then tried installing something that depends on them to the user account.