Change url() scope to avoid conflict with global aliases (e.g. Pansies)#4342
Change url() scope to avoid conflict with global aliases (e.g. Pansies)#4342rashil2000 merged 1 commit intoScoopInstaller:masterfrom
url() scope to avoid conflict with global aliases (e.g. Pansies)#4342Conversation
|
Seems like unrelated linting issues? |
|
This is an important fix. I'm guessing maintainers are overwhelmed with PRs. |
Hey, thanks for the heads up! Let me try rebasing to retrigger the CI pipeline edit: seems like there haven't been any commits to the main branch since I made this PR, I'll have to make a dummy commit |
|
Since the repo has more maintainers maybe we can get this merged? Without this change, Scoop is broken for people who use Pansies. @rasa @rashil2000 tagging some folks who may be able to move this along. Thanks for taking up maintenance of this tool! If there's anyone who is better able to move this along, please feel free to mention them. |
a6d64dd to
818162f
Compare
|
Thanks @rashil2000 @niheaven! |
|
😞 just tested it, scoop-update.sp1, line 206 calls url and not script:url. |
|
Please make a new PR |
Pansies, a popular PowerShell module, creates an alias from
urlto itsNew-Hyperlinkfunction. This conflicts with usages of theurlfunction in./lib/manifest.ps1.This PR specifies the scopes of those usages to the script level so those usages can find the function in the scoop library.
Fixes #4185