fix(shortcuts): Fix network drive shortcut creation#4410
Merged
niheaven merged 5 commits intoScoopInstaller:developfrom Jun 21, 2022
Merged
fix(shortcuts): Fix network drive shortcut creation#4410niheaven merged 5 commits intoScoopInstaller:developfrom
niheaven merged 5 commits intoScoopInstaller:developfrom
Conversation
Calls Convert-Path on Filesystem object (returned `by shortcut_folder()`) so it works on start menu mounted on network drive ScoopInstaller#3489
dwettstein
previously requested changes
Nov 8, 2021
dwettstein
left a comment
dwettstein
left a comment
There was a problem hiding this comment.
Basically this looks fine for me. I would need just two things:
- Could you please change the target branch from
ScoopInstaller:mastertoScoopInstaller:develop. - Could you please confirm that this works on network drives as well as on normal drives.
Thanks for your PR!
rashil2000
changed the title
issaclin32
previously approved these changes
Jun 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calls Convert-Path on Filesystem object (returned
by shortcut_folder()) so it works on start menu mounted on network driveCloses #3489