fix(scoop-bucket): Fix date formatting issues with git bucket(s)#4759
Merged
niheaven merged 3 commits intoScoopInstaller:developfrom Feb 25, 2022
Merged
fix(scoop-bucket): Fix date formatting issues with git bucket(s)#4759niheaven merged 3 commits intoScoopInstaller:developfrom
niheaven merged 3 commits intoScoopInstaller:developfrom
Conversation
rashil2000
previously approved these changes
Feb 24, 2022
Member
|
One more thing. I don't think we need quotes for variable. Meaning we can just say while calling git. Can you check once? |
ae45590 to
b42e740
Compare
Member
Author
|
you are right, the git command still works fine after removing them, but many code still uses quotes like this. so, i will not change them in this PR. |
Member
|
I actually wanted to remind you in your original buckets PR, but I forgot 😅
The only places where double quotes are needed are those where we use |
- scoop-bucket - scoop-status
Member
Author
|
okay, i did not notice that. also removed them from L18 of |
rashil2000
previously approved these changes
Feb 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Relates to #4756
How Has This Been Tested?
Checklist: