fix(shim): Remove character replacement in .cmd -> .ps1 shims#4914
Merged
niheaven merged 2 commits intoScoopInstaller:developfrom May 17, 2022
Merged
fix(shim): Remove character replacement in .cmd -> .ps1 shims#4914niheaven merged 2 commits intoScoopInstaller:developfrom
niheaven merged 2 commits intoScoopInstaller:developfrom
Conversation
Contributor
Author
|
@rashil2000 Could you please look at this? Any suggestions? |
rashil2000
previously approved these changes
May 16, 2022
Member
|
Why do you put two things in one PR? The |
Contributor
Author
|
@niheaven Fine. I'll separate them so that you can do the EDITED: Done. And I think the following change can be included in another PR that you will make: @@ -903,7 +903,7 @@ function applist($apps, $global) {
}
function parse_app([string] $app) {
- if($app -match '(?:(?<bucket>[a-zA-Z0-9-]+)\/)?(?<app>.*\.json$|[a-zA-Z0-9-_.]+)(?:@(?<version>.*))?') {
+ if($app -match '^(?:(?<bucket>[a-zA-Z0-9-]+)\/)?(?<app>.*\.json$|[a-zA-Z0-9-_.]+)(?:@(?<version>.*))?$') {
return $matches['app'], $matches['bucket'], $matches['version']
}
return $app, $null, $nullRef: #4910 (comment). |
scoop home and .cmd -> .ps1 shims
Member
|
In the CHANGELOG, you should mention this PR (4914), not the issue (4910).
|
niheaven
approved these changes
May 17, 2022
Contributor
Author
|
@niheaven Got it, thanks. |
This was referenced Jun 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #4910.
Motivation and Context
Partly fix #4910.
Checklist:
developbranch.